Repository navigation
fix(executor): keep the condition-join loop test off the Redis-backed isolate lease - #10275
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Low impact] The PR appears safe to merge; no new actionable issues were found. SummaryMoves the isolated-VM test doubles into one shared mock without changing production code.
Reviews (2) · Last reviewed commit: "improvement(testing): share one isolated..." · Reviewed by Greptile |
Collaborator
Author
This was referenced Nov 21, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
condition-join-loop.test.ts(added in fix(workflow-code): staging QA fixes for runtime, promote, workspace and CLI source #10262) ran its For loop's continuation check through the realexecuteInIsolatedVM. Since chore(redis): require Redis and remove the no-Redis fallbacks #10272 made Redis required, the isolate lease goes through the shared Redis mock, whoseevalanswers 0 (limit_exceeded). So the loop stopped after one iteration and the test saw['LA']instead of['LA', 'LB'].@/lib/execution/isolated-vmthe same waycondition-loop-ceiling.test.tsandtest-hooks.test.tsalready do. It evaluates only thereturn Boolean(i < n)count check, so the real condition handler and join behavior stay under test.validationworkflow failed on this test, which skipped the deploy for improvement(config): derive enterprise flags from one registry, add REGISTRATION_MODE, merge vLLM and LiteLLM #10271 and chore(redis): require Redis and remove the no-Redis fallbacks #10272.Type of Change
Testing
bun run --cwd apps/sim test executor/execution/condition-join-loop.test.ts: 2/2 pass (both failed on staging HEAD)check:test-patterns, biomeChecklist
test-auditauthoring gate)