Repository navigation
fix(executor): mock the isolate in the loop join test so staging is green - #10274
Closed
waleedlatif1 wants to merge 2 commits into
Closed
waleedlatif1 wants to merge 2 commits into
waleedlatif1 wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Low impact] The change affects only the condition-join loop test. The mock fits the loop's needs, but the shared-mock requirement must be satisfied before merging. Findings
SummaryAdds a test-only mock of
Reviews (1) · Last reviewed commit: "fix(executor): run the loop join test's ..." · Reviewed by Greptile |
…n JavaScript Add isolatedVmMock/isolatedVmMockFns to @sim/testing and use it in every test that mocked @/lib/execution/isolated-vm locally. The loop join test and test-hooks take the default plain evaluation; the loop orchestrator, function execute-request and loop ceiling tests keep their own results through isolatedVmMockFns.
Collaborator
Author
|
Superseded by #10275, which adds the shared isolated-vm mock and fixes the same test |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Staging's unit shard has been red since #10272 (Redis required) merged alongside #10262. #10272 mocked
@/lib/execution/isolated-vmintest-hooks.test.ts, but not incondition-join-loop.test.ts, which landed in #10262 minutes earlier. Without the mock, the loop's continuation check fails and the loop stops after one iteration.This adds one shared mock,
isolatedVmMock/isolatedVmMockFnsin@sim/testing, which runs the code as plain JavaScript by default. Every test that mocked the module locally now uses it:isolatedVmMockFns.Verification:
['LA','LA']).check:test-patterns,check:test-types,check:explicit-anyand lint pass.