Repository navigation
refactor(workflow-code): simplify the source dir lock release and drop casts from the QA fixes - #10276
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
[Medium impact] The PR appears safe to merge; no blocking issues were found. SummaryThe PR makes source-directory lock removal synchronous and removes casts from reference rewrites and column removal.
Reviews (2) · Last reviewed commit: "refactor(workflow-code): name the name-t..." · Reviewed by Greptile |
…upt release in one synchronous step An interrupt is handled only between event-loop turns, so a synchronous rmSync followed by the release's disposal leaves no turn in which the release could remove a lock another command took, or find this one half removed. That makes the owner-record check the last commits layered on unnecessary; it is gone.
…ping the casts at its callers
…ad of mutating it, and shrink the test-types baseline
…ause, without a type cast
…ld option check, and share the exit-code text
waleedlatif1
force-pushed
the
refactor/workflow-code-qa5-tidy
branch
from
November 21, 2026 05:12
d4fa172 to
4d90400
Compare
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #10262: the review and cleanup passes that finished after it merged.
What changed and why:
rewriteBlockNameReferencesis now generic over its input, which drops theascasts at its callers.sqlclause, without theas SQLcast.loopDataparameter instead of mutated withObject.assign. This also clears one test-types baseline entry.Behaviour is unchanged, except that the lock can no longer be left half-removed by an interrupt.
Testing:
check:test-types,check:test-patternsandcheck:explicit-anypass;