Skip to content

feat(computer-use): find and update reminders and events through app commands - #10222

Merged
waleedlatif1 merged 2 commits into
stagingfrom
feat/computer-use-edit-commands
Nov 20, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
feat/computer-use-edit-commands

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Adds two typed app commands for Reminders: find_reminders (up to 50, by list, title text or id; incomplete unless asked) and update_reminder (title, notes, due or clearDue, priority, completed). EventKit only, no scripts, nothing deleted
  • Every update gets its own confirmation that reads the reminder fresh and shows each field's current and new value; an unknown id is refused before the user is asked
  • Adds find_events (by id, or a range of at most 31 days, by calendar or title text) and update_event (title, start, end, location, notes); repeating events are refused before the user is asked, so the user picks occurrences in Calendar
  • The helper receives the values the user approved and refuses (reminder_changed / event_changed) if a field it changes moved during confirmation
  • Every string the helper returns is bounded in UTF-16 units, the schema's unit
  • The dialog says "change" for an update instead of "add"
  • Companion of the mothership contract PR; computer-use.generated.ts comes from contracts:sync
  • Draft: widens what the agent can write, so it waits on an explicit go-ahead and a paired Mac benchmark

Type of Change

  • New feature

Testing

  • service.test.ts 47/47, including new tests for event updates (repeating refused first, current → new times, approved values sent) and for the update confirmation (current → new values, unknown id refused first, declined update never sent); each guard reverted turns it red
  • Native tests on a scratch copy (macOS 26 screenshot branch stubbed): new update_reminder rejections and due round-trips pass; removing each guard turns them red
  • swiftc -typecheck clean apart from the two known macOS 26 SDK symbols; desktop and desktop-bridge type-check; biome; comment hygiene

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 20, 2026 4:00am UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] No new issue in the changes since the previous review blocks merging.

Summary

Adds reminder searches and updates through EventKit, with a fresh read before each update confirmation.

  • Computer Use can find reminders by id, list, or title.
  • Computer Use can update a reminder after the user approves the changes.
  • Computer Use now cuts returned text by UTF-16 units.

Diagram

sequenceDiagram
  participant Desktop
  participant User
  participant Helper
  participant Reminders
  Desktop->>Helper: Read reminder by id
  Helper->>Reminders: Fetch current values
  Helper-->>Desktop: Bounded reminder fields
  Desktop->>User: Show current and proposed values
  User-->>Desktop: Approve or decline
  Desktop->>Helper: Send update and approved values
  Helper->>Reminders: Read reminder again
  alt Compared fields differ
    Helper-->>Desktop: reminder_changed
  else Compared fields match
    Helper->>Reminders: Save requested fields
    Helper-->>Desktop: Updated item
  end
Loading

Reviews (3) · Last reviewed commit: "fix(computer-use): refuse stale reminder..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 6 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 marked this pull request as ready for review November 20, 2026 04:17
@waleedlatif1
waleedlatif1 merged commit 1ace34f into staging Nov 20, 2026
157 of 159 checks passed
@waleedlatif1
waleedlatif1 deleted the feat/computer-use-edit-commands branch November 20, 2026 04:17
@waleedlatif1 waleedlatif1 changed the title feat(computer-use): find and update reminders through app commands feat(computer-use): find and update reminders and events through app commands Nov 20, 2026
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

This branch was previously deployed

1 inactive deployment
Preview — f177ec7f Deployed Nov 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant