Repository navigation
fix(computer-use): tighten app-command update confirmations - #10236
Conversation
…ally, refuse mismatched date forms before asking
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
[Medium impact] This PR appears safe to merge; no blocking issues were found. SummaryThis PR tightens confirmations for app-command updates.
The previous unnumbered finding is addressed: Reviews (2) · Last reviewed commit: "Merge remote-tracking branch 'origin/sta..." · Reviewed by Greptile |
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
…lter all bidi controls, bound create titles
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
Follow-up from a final review of the app-command edit commands (#10222, #10228):
update_eventchecks both start and end against the approved values whenever either changes, since the boundary kept is saved beside the one movedcreate_reminderandcreate_eventbound the list or calendar name in their reply, like every other reply stringcomputer-use.generated.tsfromcontracts:sync(theupdate_eventstart/end description from the mothership companion)Type of Change
Testing
service.test.ts48/48; the event test now covers a NEL title, a mismatched all-day boundary refused before confirmation, and an offset time of the same moment shown unchanged (time-zone independent). Reverting each guard turns it redswiftc -typecheckclean apart from the two known macOS 26 SDK symbols; desktop and desktop-bridge type-check; biomeChecklist
test-auditauthoring gate)