Skip to content

fix(computer-use): tighten app-command update confirmations - #10236

Merged
waleedlatif1 merged 3 commits into
stagingfrom
fix/computer-use-final-review
Nov 20, 2026
Merged

waleedlatif1 merged 3 commits into
stagingfrom
fix/computer-use-final-review

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

Follow-up from a final review of the app-command edit commands (#10222, #10228):

  • update_event checks both start and end against the approved values whenever either changes, since the boundary kept is saved beside the one moved
  • A new date or time sent with an offset is shown in the Mac's local time in the confirmation, the same form as the current value, so a same-moment change doesn't read as a move
  • A date-only boundary on a timed event (or a timed one on an all-day event) is refused before the user is asked, not after
  • The confirmation's one-line filter also covers C1 controls (NEL breaks a line) and bidi controls that could reorder "current → new"
  • create_reminder and create_event bound the list or calendar name in their reply, like every other reply string
  • computer-use.generated.ts from contracts:sync (the update_event start/end description from the mothership companion)

Type of Change

  • Bug fix

Testing

  • service.test.ts 48/48; the event test now covers a NEL title, a mismatched all-day boundary refused before confirmation, and an offset time of the same moment shown unchanged (time-zone independent). Reverting each guard turns it red
  • Native tests on a scratch copy; swiftc -typecheck clean apart from the two known macOS 26 SDK symbols; desktop and desktop-bridge type-check; biome

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

…ally, refuse mismatched date forms before asking
@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 20, 2026 6:44am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] This PR appears safe to merge; no blocking issues were found.

Summary

This PR tightens confirmations for app-command updates.

  • Event updates check the event’s date form and both approved boundaries.
  • Update confirmations keep values on one line and clarify offset times.
  • Created reminders and events return bounded names.

The previous unnumbered finding is addressed: localTime now keeps the proposed offset instead of hiding it. No new actionable issues were found.

Reviews (2) · Last reviewed commit: "Merge remote-tracking branch 'origin/sta..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 11cd2cb into staging Nov 20, 2026
91 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/computer-use-final-review branch November 20, 2026 18:43

This branch was successfully deployed

1 active deployment
Preview — 976177f2 Deployed Nov 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant