Skip to content

feat(computer-use): edit calendar events and add to contacts through app commands - #10228

Merged
waleedlatif1 merged 6 commits into
stagingfrom
feat/computer-use-edit-events
Nov 20, 2026
Merged

waleedlatif1 merged 6 commits into
stagingfrom
feat/computer-use-edit-events

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Adds find_events (by id, or a range of at most 31 days, by calendar or title text; a date-only end includes that day) and update_event (title, start, end, location, notes) to the typed app commands, through EventKit only; nothing is deleted
  • Repeating events are refused before the user is asked, so the user picks occurrences in Calendar
  • Each update is confirmed against the event as it is now (current → new per field), and the helper refuses with event_changed if a field it changes moved during confirmation
  • Adds find_contacts (by id or part of a name; returns names and organization only, never emails, phones or notes) and update_contact (adds emails, phones or a group; existing values stay and duplicates are skipped; a group in another account is refused)
  • Refuses an update to a title, location or notes the read had to shorten (too_long_to_compare), for reminders as well as events
  • Every value in a confirmation is shown on one line, so a shared item's title or notes can't fake extra fields
  • Shares the update-approval path with reminders (feat(computer-use): find and update reminders and events through app commands #10222): one updateApproval builds the summary and the approved values for either kind
  • Companion of the mothership contract PR; computer-use.generated.ts comes from contracts:sync
  • Draft: widens what the agent can write, so it waits on an explicit go-ahead

Type of Change

  • New feature

Testing

  • service.test.ts 48/48, including new contact-update (unknown id refused first, name + additions + group name confirmed) and event-update tests (repeating refused before confirmation, current → new times, approved values sent); removing the repeating guard turns it red
  • Native tests on a scratch copy: update_event and find_events rejections, span checks and local-time round-trips pass; removing the time-order or 31-day guard turns them red
  • swiftc -typecheck clean apart from the two known macOS 26 SDK symbols; desktop type-check; biome

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 20, 2026 5:42am UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no new blocking issue was found.

Summary

Adds calendar event searches and updates, plus contact searches and additions.

  • Calendar events can be found and edited through app commands.
  • Agents can find contacts and add details to them.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[App command] --> B[Check app permission]
  B --> C{Update?}
  C -->|Yes| D[Read current item]
  D --> E[Build confirmation]
  C -->|No| F{Create or read?}
  F -->|Create| E
  F -->|Read| H[Run native read]
  E --> G[User approves]
  G --> I[Check values and destination]
  I --> J[Save through EventKit or Contacts]
Loading

Reviews (7) · Last reviewed commit: "fix(computer-use): find a unified contac..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 5 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1 waleedlatif1 changed the title feat(computer-use): find and update calendar events through app commands feat(computer-use): edit calendar events and add to contacts through app commands Nov 20, 2026
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 5 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 5 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 5 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 marked this pull request as ready for review November 20, 2026 05:51
@waleedlatif1
waleedlatif1 merged commit 017ac49 into staging Nov 20, 2026
89 checks passed
@waleedlatif1
waleedlatif1 deleted the feat/computer-use-edit-events branch November 20, 2026 05:51

This branch was previously deployed

1 inactive deployment
Preview — 2c408a49 Deployed Nov 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant