Repository navigation
Conversation
Regenerate the shared duration table from completed primary-file samples in hosted Ubuntu and macOS jobs. Preserve the existing shard count, deadlines, file selection, and scheduling algorithm.
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Apply the identical generated timing table from lidge-jun#8940 (d190515). Completed primary-file samples update scheduling weights only; test coverage, five-shard execution, time limits, and workflow policy remain unchanged.
Apply the identical generated timing table from lidge-jun#8940 (d190515). Completed primary-file samples update scheduling weights only; test coverage, five-shard execution, time limits, and workflow policy remain unchanged.
Apply the identical generated timing table from lidge-jun#8940 (d190515). Completed primary-file samples update scheduling weights only; test coverage, five-shard execution, time limits, and workflow policy remain unchanged.
|
✅ Deterministic PR hygiene checks passed. |
Preserve both histories and the existing stop evidence corrections. Resolve only the measured-duration table conflict with the reviewed upstream-preserving table from lidge-jun#8940 (e584532).
Preserve upstream same-handle argv reads, Hub incarnation checks, relay refresh cleanup, volatile lifecycle locks and fixture phase deadlines. Keep strict native owner evidence, Windows argv parsing, rollback retry ownership and Link recycle exclusion from this follow-up. Use the reviewed upstream-preserving timing table from lidge-jun#8940 (e584532). Native Windows acceptance remains outstanding; keep this PR in draft.
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins. |
Preserve the five shards, per-test and batch deadlines, lane selection, permissions, failure checks, and historical release evidence. Integrate current dev and append the exact workflow fingerprint after independent review of the three-file change.
Preserve the existing PR work while merging current dev. Keep five shards, individual test and batch deadlines, required checks, triggers and release identity rules. Append the reviewed workflow fingerprint without changing prior policy records. Refs lidge-jun#8940
Preserve the existing PR work while merging current dev. Keep five shards, individual test and batch deadlines, required checks, triggers and release identity rules. Append the reviewed workflow fingerprint without changing prior policy records. Refs lidge-jun#8940
Preserve the existing PR work while merging current dev. Keep five shards, individual test and batch deadlines, required checks, triggers and release identity rules. Append the reviewed workflow fingerprint without changing prior policy records. Refs lidge-jun#8940
The 18-minute shard timeout is a CI policy change tracked separately in lidge-jun#8940; this PR keeps dev's .github/workflows/ci.yml and release-evidence policy unchanged. Co-authored-by: luvs01 <luvs01@hanmail.net>
The 18-minute shard timeout is a CI policy change tracked separately in lidge-jun#8940; this PR keeps dev's .github/workflows/ci.yml and release-evidence policy unchanged. Co-authored-by: luvs01 <luvs01@hanmail.net>
* fix(responses): scope keyless loopback replay to its WebSocket Bind replay for loopback Responses clients without a context principal to the admitted WebSocket and its handshake thread. Keep scoped entries in bounded memory and release them when the socket closes. Preserve the durable replay path for callers with a principal and keep scoped writes isolated from snapshots and spill storage. Carry dev's peer-local classification alongside the replay scope during the upgrade. Co-authored-by: luvs01 <luvs01@users.noreply.github.com> * fix(responses): close replay admission and persistence review boundaries Recheck scope lifetime before mutation, reject scoped spill intake, share credential-first replay ownership, and refuse missing strict replay IDs before upstream dispatch. Preserve legacy undefined-owner behavior and durable entries across cold snapshot errors and declined scoped writes. Strengthen persistence, credential, HTTP, in-flight and fixture teardown regressions; document the strict continuation boundary in English, Korean and Spanish. * fix(responses): preserve strict replay refusal and snapshot retention Record zero-send native refusal attribution without entering recovery or upstream dispatch. Skip malformed spill digests and reserve snapshot load retries for filesystem failures. Co-authored-by: luvs01 <luvs01@hanmail.net> * fix(tests): include replay owner in Responses source inventory Cover the shared credential-first replay owner in the existing module graph, line-budget and source-oracle checks. Preserve all assertion and time limits. * ci: keep dev's timing table in the replay-scope PR Co-authored-by: luvs01 <luvs01@hanmail.net> * ci: keep dev's workflow timeout out of this replay PR The 18-minute shard timeout is a CI policy change tracked separately in #8940; this PR keeps dev's .github/workflows/ci.yml and release-evidence policy unchanged. Co-authored-by: luvs01 <luvs01@hanmail.net> --------- Co-authored-by: JUN <jun@lidgeai.com> Co-authored-by: luvs01 <luvs01@users.noreply.github.com>
|
Closing as superseded by #8944, merged in 24ae9b5. At dev e6432db, the full Ubuntu The measured |
Summary
The full Ubuntu lane exposed two separate budgeting problems: recently added files were underweighted, and the 15-minute outer job deadline still cut off healthy full-suite progress after the measured table refresh. In run 44462803582, two shards finished every file with zero failures immediately before cancellation; the one permitted retry still cancelled shard 4 after 655 of 672 files, with no failed assertion.
The measured-table refresh from the earlier commits has now been incorporated into dev
676baf650c2d2b020439341f65e1ccc57c5d3e90. Relative to that current base, this PR changes the full Ubuntujobs.test.timeout-minutesbudget from 15 to 18 minutes, updates its strict equality test, and appends the matching exact-blob approval snapshot. It keeps five shards, the scheduling algorithm, complete file selection, the 60-second per-test limit, ordinary 120-second batch deadlines, existing serial overrides up to 300 seconds, failure handling, and aggregate required-job checks. PR fast-lane selection, triggers, runner selection, permissions, macOS/Windows execution policy, and all other job budgets are unchanged.The already integrated table uses 19 hosted Ubuntu/macOS job logs and the existing parser, averaging, merge and rendering functions. It contains 3,348 paths. All 20 rows that dev
80e8952357d11ccf1421b4aa5620e781625dcdb0added or updated remain exact, including split Link stop tests; their 71 overlapping older samples are excluded. The concurrent dev changes were preserved by a normal merge. The current head has parents146909fa3e2c1b5e1bc93d1fec029d54f5ce2367and676baf650c2d2b020439341f65e1ccc57c5d3e90; its delta against current dev is exactly the three budget/test/snapshot files. The 69 Node tests, 251 CI-contract tests and type check below were rerun on that integrated tree.Release-evidence approval records are appended through the documented exact-blob procedure. The initial refresh retained all 26 historical records and appended the TSV fingerprint. This follow-up retains all 27 records and appends one snapshot that changes only the CI workflow fingerprint; its other 26 pins, policy version and required platform job counts remain identical. No release qualification rule or assertion is removed.
Why an 18-minute outer budget
Four cancellations in the same-source #840 run 44463273114 still had 18–65 files left after about 912 seconds. Those files cost 12.575–53.402 seconds in the preceding successful test run. Applying the median slowdown of matching completed files estimates complete times of 926–981 seconds (15.4–16.35 minutes). An 18-minute bound leaves about 99–154 seconds beyond that estimate for runner variation and finalization. These are extrapolations, not observed successful completions.
The additional allocation is bounded at three minutes per full Ubuntu shard. Independent process deadlines continue to stop hung batches. A second timing-only reallocation was not adopted: held-out observations did not show a consistent improvement. This follow-up retains the already reviewed timing table.
Verification
Current head —
82ee1a5a483c3e4e7756d5cb000f72ab98e376a5ci-workflows.test.ts,ci-review-lanes.test.ts,ci-shard-balance.test.ts,ci-crash-disposition.test.ts, andci-test-lane.test.ts. Executed with the normalscripts/test.ts --no-env-file --no-install --isolate --parallel=1 ... --timeout 30000wrapper in a private temporary namespace.node .github/scripts/release-evidence.cjs policy-checkpassed. Before the snapshot update, the production-pin test failed specifically for the changed workflow fingerprint; the test itself was not modified.bun check --no-script --noEmit: 2,630 files, no errors.git diff --check: passed.jobs.test.timeout-minutesis the only semantic YAML change. The strict equality assertion now expects exactly 18. The original runner, parser, selection helpers, full test manifest, timing table and Windows table are unchanged.da0b271b0d8c362a3efe98485ebfc543f64b03a2; policy blob:7df235ec7904dd19a4b2e588ecfba1da627e9972.91e18f2f58e780b45e23267ec1680e302e841cff; its tree366c68e852b6b96993c260161a9da9b5ebe6af4fexactly matches the locally validated integration tree. This is not a passing hosted result.The full local runtime suite was not repeated for this workflow metadata change during concurrent validation work. The repository's focused-validation exception applies; exact-head hosted CI remains required before merge. The local checks and the historical measurements below are not a hosted pass for this commit.
Source evidence
c38d6eef7986b3b9acbb6e8ac17407ab84e5633e: five Ubuntu and four macOS suite jobs.374867f6a068c50beaa2ec4e17e57876c88c87cc: completed primary-file samples only. The workflow was cancelled; shard 2/5's unfinished file is excluded, and shard 3/5 finished its tests before job-level cancellation. This run is not passing-suite evidence.31e5078742f928592d7f88287cdb98a688cbc975: the successful latest-attempt job set, including retained earlier successful jobs. This is PR Ubuntu evidence, separate from the cross-platform dev dispatch above.The generated header records the source job IDs, cancelled-run limitation, and preserved upstream provenance. Original log hashes and sample attribution were verified. Independent review confirmed all 20 retained values match dev exactly, and every other row and the complete path set match the existing official CLI's unfiltered refresh output. Final TSV SHA-256:
2d56880fe64338d36b424bb73178b025078ca1482da5dd4be6e73c6792759be5; Git blob:a07f90e6098082e1452ea5cc075c801271321eca.Historical local validation of the initial table refresh
bun test tests/ci-workflows/ci-shard-balance.test.ts tests/ci-workflows/ci-crash-disposition.test.ts: 42 passed / 0 failed / 6,670 assertions, with the normal preload and network guard.bun run typecheck: 2,624 files, no errors.node .github/scripts/release-evidence.cjs policy-check: passed. The CI commandnode --test .github/scripts/release-dispatch-guard.test.cjs .github/scripts/release-evidence.test.cjs .github/scripts/release-history.test.cjs .github/scripts/release-resume.test.cjs .github/workflows/deploy-docs.test.cjspassed 69 tests / 0 failures / 0 skips, including historical policy and legacy-tree checks. The original production-pin test was reproduced failing against the preceding exact CI tree before the snapshot was added.bun run privacy:scanandgit diff --check: passed.146909fa3e2c1b5e1bc93d1fec029d54f5ce2367, independent security review confirmed the two-file delta relative to dev: the generated TSV and its appended exact-blob approval snapshot. At that earlier head, workflow, runner, parser/generator, Windows table, test files and assertions remained those of dev. No credentials or raw logs are committed. That historical policy blob was51c1f898f2bdd69b7a012bd191ac51acb3c1779b; its validated tree was2b6f996c5644515021e55304530cb960ce7e7f25.The earlier table-only update used the repository's documented focused-validation exception because concurrent worktrees share limited resources. Its hosted result is recorded below; historical runs and the allocation probe are not a passing result for that head or the current candidate.
Hosted evidence before the outer-budget change — 2026-11-19
Exact head
146909fa3e2c1b5e1bc93d1fec029d54f5ce2367did not pass. In run 44462803582, attempt 1, the release-contract gate and test shards 1/5 and 2/5 passed. Shards 3/5, 4/5 and 5/5 were cancelled at the unchanged 15-minute job limit. Independent log review found no failed assertion in those three jobs.0 fail, before cancellation only 0.351 / 0.293 seconds after the last summary. Their job status is still cancelled, not successful.At 05:39 UTC, one failed-job-only retry was started for shards 3/5, 4/5, 5/5 and their dependent aggregate. Already successful jobs are retained. Attempt 2 has now completed: shards 3/5 and 5/5 passed, but 4/5 again reached the unchanged time limit. It completed 655/672 files and 60/62 batches, then stopped during batch 61, with no failed assertion. Its 17 incomplete files cost 6.990 seconds in attempt 1; that is historical context, not a pass for attempt 2. The aggregate CI check failed at 05:59:49 UTC. That earlier head remains red, and no further retry was started. A proposed second table reallocation was rejected after held-out observations regressed. The current follow-up instead changes the outer full-suite job budget to 18 minutes while preserving individual process deadlines and failure assertions.
Historical timing replay and limits
Using the retained 20 dev values and completed #840 measurements for the other files, with same-file #841 measurements filling cancellation gaps, the largest modeled Ubuntu shard load falls from 841.100 to 818.582 seconds relative to the then-current dev
80e8952. A replay over the previously observed macOS file set also improves its largest modeled load from 1,318.451 to 1,235.975 seconds.These are allocation estimates, not new CI passes. They exclude setup costs, process-boundary effects and runner variation. The original refresh's general manifest had 17 paths without a timing row, which use the existing median fallback. Changed and new macOS files have not acquired current macOS execution evidence from this refresh. Required CI and maintainer review remain necessary before merge.
Checklist
Summary by CodeRabbit