Skip to content

ci: raise the Ubuntu test shard timeout to 20 minutes - #8944

Merged
lidge-jun merged 1 commit into
devfrom
lane2/ci-test-shard-timeout-20
Nov 19, 2026
Merged

lidge-jun merged 1 commit into
devfrom
lane2/ci-test-shard-timeout-20

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Nov 19, 2026 •

Copy link
Copy Markdown
Owner

Summary

Verification

Run locally on 19a262d08a (parent ca96ead01a, current origin/dev):

  • node .github/scripts/release-evidence.cjs policy-check: "Evidence policy fingerprints match the working tree."
  • node --test .github/scripts/release-evidence.test.cjs: 26 pass, 0 fail
  • bun run typecheck: no type errors (2,633 files)
  • bun run structure:check: passed
  • bun run privacy:scan: passed
  • git diff --check: clean
  • bun test --isolate --timeout 60000 tests/ci-workflows/ci-workflows.test.ts tests/ci-workflows/ci-structure-gate.test.ts tests/ci-workflows/file-size-ratchet.test.ts tests/ci-workflows/docs-spanish-localization.test.ts tests/ci-workflows/structure-ssot.test.ts tests/test-layout.test.ts tests/test-layout-tooling.test.ts: 283 pass, 0 fail
  • bun test --isolate --timeout 60000 tests/ci-workflows: 2033 pass, 27 skip (Windows-only Authenticode cases), 0 fail across 102 files

NOT RUN: full bun run test. The change is limited to one workflow timeout, its contract test and a policy pin, and the whole tests/ci-workflows domain that covers them was run above. The workflow change itself needs the exact-head PR CI.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Summary by CodeRabbit

  • Chores
    • Linux CI test jobs now have a 20-minute time limit, up from 15 minutes—an additional five minutes before timeout. Windows test-job limits are unchanged.
    • Updated the release validation record to reflect the current CI workflow and tracked-file hashes.

Hosted ubuntu-latest shards were cancelled at the 15-minute wall in their
last batches with no failing tests (#8651 shard 1 at batch 62/65 and shard 5
at 66/66; also #8585, #8645, #8841, #8861, #8887). A cancelled shard is
neither a pass nor a fail, so it blocked merges without evidence of a fault.

Raise only the test job's timeout-minutes to 20 and pin the new ci.yml blob
with an appended release-evidence policy entry. A shard far beyond 20 minutes
is still treated as wedged.
@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner November 19, 2026 07:17
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-19T07:18:58.780170Z 19a262d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The Linux test shard timeout increases from 15 to 20 minutes. The workflow comment, timeout test, and release-evidence record are updated.

Changes: CI test shard timeout

Layer / File(s) Summary
Test shard timeout
.github/workflows/ci.yml:629-636, tests/ci-workflows/ci-workflows.test.ts:116-119, .github/scripts/release-evidence-policy.json:843-876
The Linux test shard timeout and its test expectation change to 20 minutes. The workflow comment describes prior runner cancellations and the timeout threshold. A release-evidence record is added with windowsShards set to 14 and updated workflow hash. The select-windows-runner expectation remains 2 minutes.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Possibly related PRs

  • lidge-jun/opencodex#8940: Rebalances test batches to address the same shard timeout issue; this PR changes the shard timeout instead.
Merge Risk: Minimal · up to 19a26

This raises the CI timeout for the Linux test shards so slow hosted runners are no longer cancelled before they finish. Nothing else changes, and the change is easy to revert. Merge risk is minimal once the PR's CI passes.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "ci: raise the Ubuntu test shard timeout to 20 minutes" names the primary change. The raw summary and PR objectives confirm that the five Linux/Ubuntu test shards in ci.yml move from a 15-mi…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "ci: raise the Ubuntu test shard timeout to 20 minutes" names the primary change. The raw summary and PR objectives confirm that the five Linux/Ubuntu test shards in ci.yml move from a 15-minute to a 20-minute timeout-minutes, and that the ci-workflows test expectation is updated to match. The title is specific, concise, and free of file lists or vague terms. The release-evidence policy entry is a supporting change and does not need to appear in the title.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between ca96ead and 19a262d.

Files selected for processing: 3

  • .github/scripts/release-evidence-policy.json
  • .github/workflows/ci.yml
  • tests/ci-workflows/ci-workflows.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature). label Nov 19, 2026
@lidge-jun
lidge-jun merged commit 24ae9b5 into dev Nov 19, 2026
34 of 35 checks passed
@lidge-jun

Copy link
Copy Markdown
Owner Author

Maintainer integration record: implements owner decision decision:8b360a80 (raise the Ubuntu test shard cap). Squash-merged on exact head 19a262d with all 31 required checks green, security review approved on this head (only the test job's timeout-minutes changed; parsed workflow otherwise identical; release-evidence policy additions-only with the ci.yml pin matching the tree), and assert-mergeable-review.sh --maintainer-integration OK. Merge result equals the PR tree on dev ca96ead; typecheck, structure:check, policy-check, 26 evidence tests, ci-workflows/ratchet/Spanish-localization and test-layout guards passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant