Repository navigation
Conversation
Walkthrough
Merge Risk:
|
|
✅ Deterministic PR hygiene checks passed. |
|
@coderabbitai review |
Action not completed
|
|
@coderabbitai review Please review the latest head |
Action performed
|
Preserve POSIX recorded-path trust checks and current Windows census and packed-command behavior. Preserve both sides of the test-layout registry without changing its established formatting. Validation: focused synthetic/loopback coverage, typecheck, structure and privacy checks; file-size gate passed after retaining the upstream registry format. Independent conflict-resolution review found no blocker.
|
No description provided. |
Summary
Remote Link treats a recorded runtime path as a discovery hint. Previously its first version probe could execute the recorded binary or package entrypoint before checking who controls that path.
lscan silently treat an ACL read failure as an absent ACL. Reusing macOS hints needs a native ACL reader that distinguishes those outcomes along the entire path. Existing Desktop, system and PATH discovery continues.Addresses the Daybreak finding and the macOS ACL review finding.
Current base:
c36793a9336b70cfe5bc3b7f6e6f751e730fb6fc. Current head:06ba9b29f68e9ccf997b2d142dddc8b11516d3d0. Independently reviewed current tree:80cead81554d9047e432c33e4f92c49af11642f5.The earlier implementation and verification below used base
e87572127d7804216ebfcf0feecaf4c22c181748and tree8beec34186cc08bd34d214a233425c5dcfcc5d15.Compatibility and limits
A macOS installation available only through its runtime record is no longer selected or detected. Add it to the SSH account's PATH or install it in an existing discovery location. Full-install census, including the
--require-ephemeralcheck, can only detect the remaining known install locations on macOS; it may proceed when a record-only full install exists. This change does not execute or remove that undiscovered installation.This change removes the extra execution authority provided by arbitrary census paths. Existing Desktop/system locations and the SSH account's PATH retain their prior executable/version checks; this PR does not add ownership or ACL validation to those fallback locations. A path rejected through the census can still execute if it is independently selected through one of those locations. A controlled writable-Desktop fixture produces the same calls across all four consumers with and without a census record, confirming that this is an existing fallback policy rather than authority granted by the record.
The checks do not claim protection against root or unrestricted same-account mutation. The shell checks do not bind an opened executable descriptor through execution.
Verification
Current maintenance verification — 2026-11-17
devc36793awithout dropping either the recorded-runtime trust contract or the newer Windows census/packed-script contract. The test-layout fixture retains all 3,285 base mappings plus this PR's new trust test, in the existing compact format.statfallback to%u %Mp%03Lp: the middle field preserves sticky/setuid/setgid bits, and the zero-padded low field preserves values such as1007and4005. GNU formatting and the Linux-only admission gate are unchanged. This follows Apple's field handling and format specification.Historical verification before this maintenance pass
Verification on Linux, Bun 1.4.4, isolated local filesystem and harmless executable fixtures:
cefa181: 235 passed / 20 Windows skips / 0 failed / 1,491 assertions acrosslink-served-runtime-trust,link-ssh-argv-discovery,link-gated-ocx-argv,link-pinned-sync-argv,link-child-update-launcher,link-full-install-census,link-ssh-argv, both test-layout guards and the file-size ratchet.1f312fd: 74 passed / 18 Windows skips / 0 failed / 383 assertions across discovery and trust tests; typecheck, privacy, size and whitespace checks passed again. The correction keeps trust tools present when census-tool regressions are tested, without changing production code or the default fixture tools.7b6a9a17: 10 new platform regressions failed / 20 Linux controls passed.bun run typecheck: 2,537 files, no errors.bun run structure:check,bun run privacy:scan,bun scripts/file-size-ratchet.tsand staged whitespace checks passed.Foreign-owner and BSD-format metadata use local shims. Darwin behavior uses a synthetic
unamefixture, not a macOS host. No live SSH endpoint, provider, real credential, Windows runtime or installed application was exercised.The broad local suite and
test:changedwere not run because the broader graph previously selected a real provider. Focused scripts execute only generated shell against local fixtures. Historical automatic CI passed for head1f312fd00ffc81246889d5f3bb35b13f3c538717: main workflow and Catalog async contracts. The main workflow tested PR merge preview795de27612d26baf833427413563cd24bede5f46; all 15 executed jobs, including all five Ubuntu test shards, passed. Native macOS/Windows lanes were skipped by repository policy. Final-head hygiene and Devin status also passed; the two original review threads were resolved. CodeRabbit completed its full review oncefa181with one fixture-isolation comment, addressed in1f312fdafter independent review. The macOS ACL finding was also fixed and Devin confirmed it resolved. At that earlier stage, a new full CodeRabbit request was not made after the included review allowance was exhausted. This PR remains Draft for maintainer security review and platform acceptance.Checklist
The last item records implementation and independent source review, not maintainer approval.
Summary by CodeRabbit
PATH. On macOS, installations available only through recorded paths must be made discoverable another way.