Repository navigation
fix(ocx-child): bound WebSocket event retention - #8801
Conversation
Consume completed frame events before parsing later messages in the same read. Handle payload reservation failure as a connection fault and preserve the existing test-only feature gate, framing limits, and close behavior.
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
✅ Deterministic PR hygiene checks passed. |
|
Maintainer integration into
|
Summary
link-ws-test-gateabsent from ordinary builds. Add bounded parser coverage, a real feature-enabled relay regression, and the owning runtime contract.Verification
Recorded local validation:
cargo test --locked --manifest-path native/ocx-child/Cargo.toml --lib: 57 passed, 0 failed.cargo test --locked --manifest-path native/ocx-child/Cargo.toml --features link-ws-test-gate --lib --test link_websocket: 56 library tests and 5 real-binary integration tests passed.bun run typecheck(2,533 files),bun run structure:check,bun run privacy:scan, file-size ratchet, Rust formatting, and staged diff checks passed.Upstream validation for
bf259f16c346accb29f91121e3562b509860b2dbpassed: Cross-platform CI and PR gates. The Ubuntu remote-helper job ran ocx-child formatting, clippy and default-feature Cargo tests successfully. The feature-enabledlink_websocketreal-binary result is the recorded local result above; it was not run by that CI job. Skipped Bun/full/native-platform lanes are not claimed as executed.An additional read-only review of this exact commit covered event-buffer ownership, frame/protocol boundaries, reservation failure, teardown and feature gating, and found no blocking issue. It did not rerun tests or perform an OOM or live installation test. Installed/live application validation and explicit maintainer security review before merge remain separate.
Checklist
The security checkbox records implementation review; explicit maintainer security review remains required before merge.
Summary by CodeRabbit
Bug Fixes
Tests
Documentation