Repository navigation
fix(vertex): bind model discovery to Google destinations - #8802
Conversation
Validate the discovery destination before resolving ADC or ambient credentials, bind asynchronous credentials to that origin, and recheck the exact outgoing URL for initial and paginated catalog requests. Add regressions for hostile destinations and provider changes during credential resolution.
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
✅ Deterministic PR hygiene checks passed. |
|
Maintainer integration into
|
Summary
Verification
Recorded local validation:
bun scripts/test.ts --parallel=1 tests/adapters/google/vertex-model-discovery.test.ts tests/adapters/google/vertex-catalog.test.ts tests/server/management-provider-model-discovery.test.ts: 56 passed, 0 failed, 312 assertions on the final staged tree.bun run typecheck(2,533 files),bun run structure:check,bun run privacy:scan, and diff checks passed.Posted-head CI 43812045079 passed, including the Typecheck step and test changed job. Catalog checks also passed. This is exact-head hosted evidence; the local results above are retained prior validation and were not rerun for this status change.
A source comparison against dev
c36793a9336b70cfe5bc3b7f6e6f751e730fb6fcfound no duplicate implementation or incompatible contract change requiring a rebase. Maintainer security review and installed/live application validation remain separate; review readiness does not claim merge or release acceptance.Checklist
The security checkbox records implementation review; explicit maintainer security review and the repository's
maintainer-sponsoredrequirement for authentication surfaces remain required before merge.Summary by CodeRabbit