Repository navigation
Conversation
Consume completed frame events before parsing later messages in the same read. Handle payload reservation failure as a connection fault and preserve the existing test-only feature gate, framing limits, and close behavior.
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
✅ Deterministic PR hygiene checks passed. |
|
No description provided. |
Summary
link-ws-test-gateabsent from ordinary builds. Add bounded parser coverage, a real feature-enabled relay regression, and the owning runtime contract.This addresses the Daybreak finding. The branch is based on
devat1d10758fa6ced80cdd780cb000bc5c4b83f84703; its reviewed tree is01f85f6d7ef39df5e6ab5dc024d04489b10f2653.Verification
Linux, Rust 1.90.0 and Bun 1.4.4:
cargo test --locked --manifest-path native/ocx-child/Cargo.toml --lib: 57 passed, 0 failed.cargo test --locked --manifest-path native/ocx-child/Cargo.toml --features link-ws-test-gate --lib --test link_websocket: 56 library tests and 5 real-binary integration tests passed.bun run typecheck(2,533 files),bun run structure:check,bun run privacy:scan, file-size ratchet, Rust formatting, and staged diff checks passed.write_frame, control frames, and terminal error handling.Unresolved validation: the attempted default full Cargo suite stopped after 121 passing tests and 1 failure,
owner_link::a_relay_of_another_home_keeps_the_planted_binary_from_being_purged, with OS error 26 (Text file busy). The same isolated test passed on the unchanged base, so this failure is unclassified, not asserted to be a proven baseline failure. The full suite was not rerun to obtain a green result. Windows/macOS and an installed application were not tested.Hosted follow-up: the existing Linux remote-helper CI job ran the default full
ocx-childCargo suite with Rust 1.100.0: 133 passed, 0 failed, including the locally failing owner-link test. Its merge-preview commit43cbda04e7af30acb1664aad2730ed695372d144has the exact reviewed tree01f85f6d7ef39df5e6ab5dc024d04489b10f2653, equal to this PR head. The local OS-26 result above remains recorded and unclassified; the hosted result independently verifies the same patch content. This hosted job does not enablelink-ws-test-gate; the feature-enabled coverage is the separate local run above.This PR remains Draft for maintainer security review and full platform acceptance. No production feature gate is enabled.
Checklist
The last item records implementation and independent source review; it does not claim maintainer approval or full platform acceptance.
Summary by CodeRabbit
Upstream handoff
The complete four-file change is preserved in lidge-jun/opencodex#8801 at the same head
bf259f16c346accb29f91121e3562b509860b2db. Its exact-head main CI and CodeRabbit review completed successfully, with no unresolved inline review threads at verification. Closing this duplicate fork PR; follow-up continues in lidge-jun#8801. The shared source branch is retained. This is not a merge or platform-acceptance claim.