Repository navigation
Quarantine intermittent HeaderPlusOne split-packet test - #5073
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Quarantine evidence, validation and incomplete discovery checkpoint - 2026-11-16Supported category-only changeExact identity: // SqlException: connection timed out consuming the pre-login handshake acknowledgement.
[Trait("category", "flaky")]Both existing target frameworks, net462 and net10.0, receive the method category. Proposal commit: Exact failure and passing controlBoth observations are from CI-SqlClient definition 1879, build 192284,
Observed failure: Configuration is identical for the two observations:
Mapped evidence:
Rationale: one exact Fact fails and passes with no revision, job or configuration change. Discovery interval, inventories and coverage boundaryNo reliable complete tagging checkpoint was found in the prior tagging records. Live definition identity/status checks found the seven allowed definitions enabled.
First actual finish: 2026-11-02T17:08:10.7991101Z. Build inventory complete; broader per-test review incomplete.
Result IDs were unique within each run; identities are Additional build-helper discovery: The build-wide Passed query for 188372 failed: Checkpoint NOT ADVANCED. The next tagging run must rescan its full 14-day window Other candidates and deduplication
Live historical inputs #4980 and Local validationCommands ran in this automation's isolated worktree only: dotnet restore src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTests.csproj -p:Configuration=Release -v:q
dotnet test src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTests.csproj --no-restore -c Release --list-tests --filter "FullyQualifiedName~Microsoft.Data.SqlClient.ManualTesting.Tests.SplitPacketTest.&category=flaky" -v:q
dotnet test src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTests.csproj --no-build --no-restore -c Release --list-tests --filter "FullyQualifiedName~Microsoft.Data.SqlClient.ManualTesting.Tests.SplitPacketTest.&category!=failing&category!=flaky&category!=interactive" -v:q
dotnet test src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTests.csproj --no-build --no-restore -c Release --filter "FullyQualifiedName=Microsoft.Data.SqlClient.ManualTesting.Tests.SplitPacketTest.HeaderPlusOneTest&category=flaky" -v:q --logger 'trx;LogFilePrefix=header-plus-one' --results-directory 'C:\Users\mdaigle\.copilot\session-state\dcaa48f9-f8fc-4e46-8196-2ebd2ef83d07\files\validation' --blame-hang-timeout 2m
git diff --check
Current canonical upstream version resolved to 8.1.0-preview1, Fixes, fix proposals, all probation lifecycle actions and promotions are outside this |
There was a problem hiding this comment.
🔵 Needs a closer look
Policy compliance could not be fully checked because trusted review-policy references from protected configuration or an immutable base were not supplied.
No open issues 🎉
What changed in this PR
Quarantines the intermittently failing HeaderPlusOneTest in SqlClient’s manual split-packet tests without changing test behavior or product code.
Changes:
- Adds a method-level
flakycategory toHeaderPlusOneTest. - Adds a comment recording the observed pre-login handshake timeout; existing sibling quarantines and pipeline configuration remain unchanged.
| File | Description |
|---|---|
| src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/SplitPacketTest/SplitPacketTest.cs | Marks HeaderPlusOneTest as flaky and documents the observed timeout. |
Review effort: Balanced
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5073 +/- ##
==========================================
+ Coverage 68.99% 69.93% +0.94%
==========================================
Files 314 314
Lines 45857 69767 +23910
==========================================
+ Hits 31638 48793 +17155
- Misses 14219 20974 +6755
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🤖 This pull request was created by a fully automated workflow.
Description
Add
[Trait("category", "flaky")]and an observed-error comment to this unparameterized Fact:Microsoft.Data.SqlClient.ManualTesting.Tests.SplitPacketTest.HeaderPlusOneTestThe exact Fact timed out consuming the pre-login handshake acknowledgement, then passed in the same ordinary task's retry. Both observations use CI-SqlClient build 192284, main revision
5f74e8f13e38, Windows Server 2022 / SQL22 image / net462 / native SNI / x64 / Release / Project / Set 3, job attempt 1.No configuration or revision changed between observations. Method-level quarantine affects this Fact on both frameworks; all test bodies, conditions, other categories and three ordinary siblings remain unchanged. No product, API, pipeline, repair or probation changes. This is quarantine, not a stability claim.
Issues
Related: #5065 quarantined the distinct
MARSSplitTest; #5047's existingFullHeaderTestquarantine is untouched. No issue is closed. Fixes and all probation lifecycle work are outside this automation's scope.Testing
Both framework builds/discovery passed: quarantine selects exactly three split-packet Facts; ordinary selection excludes them and retains three siblings.
git diff --checkpassed. Exact commands/results and the complete evidence/checkpoint record are in the collapsed evidence comment.Local execution was 0 passed / 1 skipped on each framework because configuration predicates threw
TargetInvocationException; skipped-only execution is not passing coverage. Three CI run inventories (13,943 top-level results) were reconciled. The 525-build inventory covers 2026-11-02T16:56:18Z–2026-11-16T16:56:18Z, but broader per-test review remains incomplete after a build-wide MCP transport failure. Discovery checkpoint not advanced.Guidelines
Please review the contribution guidelines before submitting a pull request: