Repository navigation
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Quarantine evidence, validation and incomplete discovery checkpoint - 2026-11-19Category-only scope and exact identity
Verified failures and actual passing controlsAll three results have
Observed failure: Both builds are CI-SqlClient / definition 1879, refs/heads/main.
Mapped logs were read with authenticated MCP in bounded ranges. The failed Both jobs use Windows Server 2022 10.0.20348, x64, net10.0, native SNI, Test-specific eligibility, not merely intermittencyEventSourceTest.cs at the failing revision That concrete listener-lifecycle/collection weakness matches the observed Build interval, coverage and checkpointNo reliable fully processed tagging checkpoint was found in the prior durable Authenticated MCP build pages were bounded (25 initially, then 100) and followed
All seven identities were rechecked as Enabled. sqlclient-ci-stress (2250) was CI-SqlClient inventory includes main 46, release/6.1 7, release/7.0 11, Build-helper failure-outcome discovery was performed for main builds The Both relevant runs were then enumerated without outcome filtering in six
Counts reconcile exactly to the server run statistics and totalTests; both Checkpoint NOT ADVANCED. Remaining evidence includes the other runs in Other observed candidates and existing proposals
Open quarantine/fix/backport proposals and equivalent human titles/scopes were Release routing and milestoneNo release branch qualifies for this new Fact quarantine on this evidence. Latest checked upstream main is Validation commands and actual resultsThe following build/discovery commands both succeeded and each listed exactly dotnet test 'src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTests.csproj' --framework net10.0 --list-tests --filter 'FullyQualifiedName=Microsoft.Data.SqlClient.ManualTesting.Tests.EventSourceTest.EventSourceTestAll&category=flaky' --verbosity quiet
dotnet test 'src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTests.csproj' --framework net462 --list-tests --filter 'FullyQualifiedName=Microsoft.Data.SqlClient.ManualTesting.Tests.EventSourceTest.EventSourceTestAll&category=flaky' --verbosity quietActual routing was then asserted on both frameworks with the following $p='src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTests.csproj'
$n='FullyQualifiedName=Microsoft.Data.SqlClient.ManualTesting.Tests.EventSourceTest.EventSourceTestAll'
foreach ($f in 'net462','net10.0') {
dotnet test $p -f $f --no-build --no-restore --list-tests --filter "$n&category=flaky" -v:q
dotnet test $p -f $f --no-build --no-restore --list-tests --filter "$n&category!=failing&category!=flaky&category!=interactive" -v:q
}Focused execution attempts used these exact commands: dotnet test 'src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTests.csproj' --framework net10.0 --no-build --no-restore --filter 'FullyQualifiedName=Microsoft.Data.SqlClient.ManualTesting.Tests.EventSourceTest.EventSourceTestAll&category=flaky' --verbosity quiet
dotnet test 'src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTests.csproj' --framework net462 --no-build --no-restore --filter 'FullyQualifiedName=Microsoft.Data.SqlClient.ManualTesting.Tests.EventSourceTest.EventSourceTestAll&category=flaky' --verbosity quiet
dotnet test 'src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTests.csproj' --framework net462 --no-build --no-restore --filter 'FullyQualifiedName=Microsoft.Data.SqlClient.ManualTesting.Tests.EventSourceTest.EventSourceTestAll&category=flaky' --logger 'console;verbosity=normal' --verbosity quiet
Fixes and all probation lifecycle work are outside scope. No pipeline was Publication verificationCreated #5118, commit Live metadata verified Area\Tests, milestone 8.1.0-preview1 (#108), |
There was a problem hiding this comment.
🔵 Needs a closer look
Policy-specific quarantine eligibility requires human verification because the supplied checkout-relative policy references lack trusted-base provenance.
No open issues 🎉
What changed in this PR
Quarantines EventSourceTestAll in the SqlClient manual test suite to keep its intermittent listener-enumeration failure out of regular test runs. This changes test routing, not the underlying behavior.
Changes:
- Adds a method-level
[Trait("category", "flaky")]. - Adds a comment describing the observed collection-modification exception.
- Leaves the test body, conditions, sibling tests, APIs, and pipelines unchanged.
| File | Description |
|---|---|
src/Microsoft.Data.SqlClient/tests/ManualTests/TracingTests/EventSourceTest.cs |
Marks EventSourceTestAll as flaky and documents the observed failure. |
Review effort: Balanced
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5118 +/- ##
==========================================
+ Coverage 68.99% 70.40% +1.41%
==========================================
Files 314 315 +1
Lines 45857 70026 +24169
==========================================
+ Hits 31638 49304 +17666
- Misses 14219 20722 +6503
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🤖 This pull request was created by a fully automated workflow.
Description
Quarantine the unparameterized Fact
Microsoft.Data.SqlClient.ManualTesting.Tests.EventSourceTest.EventSourceTestAllwith a method-level
[Trait("category", "flaky")]and the required observed-errorcomment. Its body, condition,
Set=3, other categories and sibling tests areunchanged; routing applies on net462 and net10.0. No APIs or pipelines change.
6a1ad2ad846f6a1ad2ad846f981a989dd1b4Both jobs use Windows Server 2022, net10.0 native SNI, SQL22 matrix, Release/Project,
Set 3 and image 106.0.0. The independent pass advances main by async-AE #5080;
this Fact, its listener helper and test-step template are unchanged.
The test enumerates a mutable
List<int>while its event listener remains enabledand can append to that list. This source-backed lifecycle/collection weakness
matches the observed
InvalidOperationException; generic connectivity does notexplain that symptom. A successful retry alone is not the eligibility rationale.
This is quarantine, not a repair or stability claim.
No release branch has a verified within-branch qualifying pair for this Fact;
no Hotfix label/backport requested. Fixes and probation are outside scope.
Issues
No equivalent pending proposal found. #5095 quarantines a different MARS Fact;
#5117/#5085 concern an enclave retry product defect, not this listener assertion.
Complete collapsed evidence and run record,
including configuration comparisons, related PRs, unconfirmed candidates and checkpoint status.
Testing
Both framework builds/discoveries succeeded. Actual routing checks below produced
exactly one quarantined Fact and intentional ordinary exclusion per framework:
Focused execution: net10.0 skipped (0 passed/0 failed/1 skipped); net462
failed during database login (0 passed/1 failed/0 skipped: Northwind unavailable
to the configured login). Neither establishes local execution/stability coverage.
The linked record retains exact build/execution commands and results.
git diff --checkpassed; the diff is two added lines in one file.Discovery interval: 2026-11-05T16:52:41.935Z–2026-11-19T16:52:41.935Z.
527 builds inventoried; two full run inventories reconcile 11,150 results.
Broader per-test coverage remains incomplete after an MCP transport failure;
checkpoint not advanced.
Guidelines
Please review the contribution guidelines before submitting a pull request:
Contributing
Code of Conduct
Best Practices
Coding Style
Review Process
Tests added or updated (category and observed-error comment only).
Public API changes documented (not applicable).
Verified against customer repro (not applicable; local execution blocked/skipped).
Ensure no breaking changes introduced.