Repository navigation
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Quarantine evidence, validation and incomplete discovery checkpoint - 2026-11-17Supported category-only changeExact identity: // Assert.Fail: parallel MARS commands reported Execution Timeout Expired.
[Trait("category", "flaky")]The Fact's conditions, class-level Exact failure and passing controlsAll observations below are for that exact, unparameterized Fact, with empty subResults.
Observed failure: the Fact catches an AggregateException from its parallel commands and Both decisive runs independently identify Configuration: Windows 11, x64, net10.0, managed SNI, Project references, Release, Mapped, authenticated MCP logs:
The UTC ranges in the table are the test-result service's observed fields. Test-specific eligibility, not just intermittency
The observed failure occurs executing commands after connection and table setup, not Discovery interval, inventory and coverage boundaryPrior tagging records #4980, #4996, #5047 and #5073 were read live. All seven specified definitions were rechecked by authenticated MCP for exact
CI-SqlClient inventory includes main (49), release/6.1 (10), release/7.0 (13), Build inventory complete; broader per-test review incomplete. Two relevant full runs were paginated with authenticated MCP (1,000-result bounded
Both runs are Completed with incompleteTests=0. Passed counts sum duplicate Checkpoint NOT ADVANCED. The next tagging run must rescan its full 14-day window Unconfirmed / excluded observations
No same-test/symptom release-branch failing/passing pair was established for Related proposals and state
Local validation and limitationsExact commands executed from the isolated worktree: dotnet test src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTests.csproj --framework net10.0 --list-tests --filter 'FullyQualifiedName=Microsoft.Data.SqlClient.ManualTesting.Tests.MARSTest.MarsConcurrencyTest&category=flaky' --verbosity quiet
dotnet test src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTests.csproj --framework net10.0 --no-build --no-restore --list-tests --filter 'FullyQualifiedName=Microsoft.Data.SqlClient.ManualTesting.Tests.MARSTest.MarsConcurrencyTest&category!=failing&category!=flaky&category!=interactive' --verbosity quiet
dotnet build src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTests.csproj --framework net462 --no-restore --verbosity quiet
dotnet test src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTests.csproj --framework net462 --no-build --no-restore --list-tests --filter 'FullyQualifiedName=Microsoft.Data.SqlClient.ManualTesting.Tests.MARSTest.MarsConcurrencyTest&category=flaky' --verbosity quiet
dotnet test src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTests.csproj --framework net462 --no-build --no-restore --list-tests --filter 'FullyQualifiedName=Microsoft.Data.SqlClient.ManualTesting.Tests.MARSTest.MarsConcurrencyTest&category!=failing&category!=flaky&category!=interactive' --verbosity quiet
dotnet test src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTests.csproj --framework net10.0 --no-build --no-restore --filter 'FullyQualifiedName=Microsoft.Data.SqlClient.ManualTesting.Tests.MARSTest.MarsConcurrencyTest&category=flaky' --verbosity quiet
git diff --checkResults: the first command built net10.0 and selected exactly the intended Fact. Operational errors/limitations: the optional signing-config lookup returned unset; Release assignment and publication requirementsFresh main SqlClientNextVersion is Fixes and all probation lifecycle work remain outside this tagging automation's scope. |
There was a problem hiding this comment.
🔵 Needs a closer look
Human review is needed because no trusted immutable source was established for the required review policies and references, leaving the policy check incomplete.
No open issues 🎉
What changed in this PR
Quarantines the intermittent MarsConcurrencyTest manual test without changing driver behavior or attempting to fix the underlying shared-connection concurrency issue.
Changes:
- Adds
[Trait("category", "flaky")]to this Fact on both target frameworks. - Adds a comment recording the observed parallel-command execution timeouts.
- Preserves the test body, conditions, other categories, and sibling tests.
| File | Description |
|---|---|
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/MARSTest/MARSTest.cs |
Marks MarsConcurrencyTest as flaky and documents the observed failure. |
Review effort: Balanced
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5095 +/- ##
==========================================
+ Coverage 68.99% 72.50% +3.51%
==========================================
Files 314 314
Lines 45857 71062 +25205
==========================================
+ Hits 31638 51525 +19887
- Misses 14219 19537 +5318
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🤖 This pull request was created by a fully automated workflow.
Description
Quarantine the unparameterized Fact
Microsoft.Data.SqlClient.ManualTesting.Tests.MARSTest.MarsConcurrencyTestusing
[Trait("category", "flaky")]and an observed-error comment.Only that method is affected on net462/net10.0; its body, conditions,
Set=3,other categories and sibling tests are unchanged.
0304c75eb0480304c75eb048Both use Windows 11, net10.0, managed SNI, Azure SQL, Release/Project, Set 3,
attempt 1, image 56.0.0. The test shares one connection across parallel command
workers despite MARS operations not being thread-safe.
This concrete test-design weakness supports quarantine, not a claim that every
Azure timeout is a test defect or that the underlying behavior is repaired.
No APIs, product code or pipelines change. No fixes or probation changes.
Release-branch intermittency for this Fact remains unconfirmed; no backport label requested.
Full-window per-test discovery is incomplete and the checkpoint is not advanced.
Issues
#4589 reports this different, already-open-connection scenario but contains no
equivalent repair/quarantine. #5073 quarantines a different Fact.
Complete evidence and run record, including the inspected interval, unconfirmed candidates and incomplete-coverage boundary.
Testing
Actual quarantine selection and ordinary exclusion verified on both target frameworks.
net462build passed with zero warnings/errors; the net10.0 discovery command also built.Focused SQL execution was skipped because the isolated worktree lacks test configuration:
zero passed, zero failed, one skipped. This is not execution or stability coverage.
git diff --checkpassed.Result: exactly one quarantined Fact and intentional ordinary exclusion per framework.
The linked evidence record retains the build/execution commands and limitations.
Guidelines
Please review the contribution guidelines before submitting a pull request:
Contributing
Code of Conduct
Best Practices
Coding Style
Review Process
Tests added or updated (category and observed-error comment only).
Public API changes documented (not applicable).
Verified against customer repro (not applicable; local SQL execution skipped).
Ensure no breaking changes introduced.