Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions dataset/src/main/scala/frameless/TypedColumn.scala
Original file line number Diff line number Diff line change
Expand Up @@ -605,6 +605,18 @@ abstract class AbstractTypedColumn[T, U](
): SortedTypedColumn[T, U] =
new SortedTypedColumn[T, U](untyped.asc)

def asc_nulls_first(implicit catalystOrdered: CatalystOrdered[U]): SortedTypedColumn[T, U] =
new SortedTypedColumn[T, U](untyped.asc_nulls_first)

def asc_nulls_last(implicit catalystOrdered: CatalystOrdered[U]): SortedTypedColumn[T, U] =
new SortedTypedColumn[T, U](untyped.asc_nulls_last)

def desc_nulls_first(implicit catalystOrdered: CatalystOrdered[U]): SortedTypedColumn[T, U] =
new SortedTypedColumn[T, U](untyped.desc_nulls_first)

def desc_nulls_last(implicit catalystOrdered: CatalystOrdered[U]): SortedTypedColumn[T, U] =
new SortedTypedColumn[T, U](untyped.desc_nulls_last)

/**
* Bitwise AND this expression and another expression.
* {{{
Expand Down
4 changes: 4 additions & 0 deletions dataset/src/test/scala/frameless/OrderByTests.scala
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ class OrderByTests extends TypedDatasetSuite with Matchers {
def sortings[A: CatalystOrdered, T]: Seq[(TypedColumn[T, A] => SortedTypedColumn[T, A], Column => Column)] = Seq(
(_.desc, _.desc),
(_.asc, _.asc),
(_.desc_nulls_first, _.desc_nulls_first),
(_.desc_nulls_last, _.desc_nulls_last),
(_.asc_nulls_first, _.asc_nulls_first),
(_.asc_nulls_last, _.asc_nulls_last),
(t => t, t => t) // default ascending
)

Expand Down
Loading