Repository navigation
added-asc-desc-null-typed-columns added the columns and added them to… - #987
SabrinaXKL wants to merge 3 commits into
Conversation
jducoeur
left a comment
There was a problem hiding this comment.
On second look -- I think the code looks reasonable, but you should adjust the code style to match the rest of the file. Needs you to run scalafmt, I suspect?
(And you've got a merge conflict, although that looks easy to fix.)
… OrderByTests # Conflicts: # dataset/src/main/scala/frameless/TypedColumn.scala # dataset/src/test/scala/frameless/OrderByTests.scala
893fb53 to
a66a762
Compare
Done :) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #987 +/- ##
==========================================
- Coverage 96.23% 96.23% -0.01%
==========================================
Files 68 66 -2
Lines 1328 1300 -28
Branches 48 49 +1
==========================================
- Hits 1278 1251 -27
+ Misses 50 49 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
added some typed columns ordering for asc/desc nulls, as described by the issue here #164