Skip to content

added-asc-desc-null-typed-columns added the columns and added them to… - #987

Open
SabrinaXKL wants to merge 3 commits into
typelevel:masterfrom
SabrinaXKL:added-aesc-desc-null-typed-columns
Open

SabrinaXKL wants to merge 3 commits into
typelevel:masterfrom
SabrinaXKL:added-aesc-desc-null-typed-columns

Conversation

@SabrinaXKL

Copy link
Copy Markdown

added some typed columns ordering for asc/desc nulls, as described by the issue here #164

@jducoeur jducoeur left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second look -- I think the code looks reasonable, but you should adjust the code style to match the rest of the file. Needs you to run scalafmt, I suspect?

(And you've got a merge conflict, although that looks easy to fix.)

… OrderByTests

# Conflicts:
#	dataset/src/main/scala/frameless/TypedColumn.scala
#	dataset/src/test/scala/frameless/OrderByTests.scala
@SabrinaXKL
SabrinaXKL force-pushed the added-aesc-desc-null-typed-columns branch from 893fb53 to a66a762 Compare November 10, 2026 23:07
@SabrinaXKL

Copy link
Copy Markdown
Author

On second look -- I think the code looks reasonable, but you should adjust the code style to match the rest of the file. Needs you to run scalafmt, I suspect?

(And you've got a merge conflict, although that looks easy to fix.)

Done :)

@codecov

codecov Bot commented Nov 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.23%. Comparing base (c5e87a5) to head (da18baa).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #987      +/-   ##
==========================================
- Coverage   96.23%   96.23%   -0.01%     
==========================================
  Files          68       66       -2     
  Lines        1328     1300      -28     
  Branches       48       49       +1     
==========================================
- Hits         1278     1251      -27     
+ Misses         50       49       -1     
Flag Coverage Δ
2.13-root-spark35 ?
2.13-root-spark40 96.23% <100.00%> (+0.01%) ⬆️
2.13-root-spark41 ?
2.13-root-spark42 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants