Repository navigation
[SCAL-266165] [DO NOT MERGE] Test Theme Builder sync review rule - #753
Open
tushardeepakts wants to merge 1 commit into
Open
tushardeepakts wants to merge 1 commit into
tushardeepakts wants to merge 1 commit into
Conversation
Adds one dummy CustomCssVariables property with no Theme Builder PR link, to check that the Claude review posts the red MUST comment. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a test-only CSS variable --ts-var-test-theme-builder-sync-color to CustomCssVariables in src/css-variables.ts. The reviewer pointed out that any new CSS variable added to CustomCssVariables must be synced with the Theme Builder, requiring a link to the corresponding Theme Builder PR or sync configuration before merging.
Comment on lines
+1956
to
+1960
| /** | ||
| * Test-only variable for checking the Theme Builder sync review rule | ||
| * (SCAL-266165). Do not merge. | ||
| */ | ||
| '--ts-var-test-theme-builder-sync-color'?: string; |
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds one dummy CustomCssVariables property with no Theme Builder PR link, to check that the Claude review posts the red MUST comment.