Skip to content

[SCAL-266165] [DO NOT MERGE] Test Theme Builder sync review rule - #753

Open
tushardeepakts wants to merge 1 commit into
SCAL-266165-theme-builder-sync-review-rulefrom
SCAL-266165-test-theme-builder-rule
Open

tushardeepakts wants to merge 1 commit into
SCAL-266165-theme-builder-sync-review-rulefrom
SCAL-266165-test-theme-builder-rule

Conversation

@tushardeepakts

Copy link
Copy Markdown
Collaborator

Adds one dummy CustomCssVariables property with no Theme Builder PR link, to check that the Claude review posts the red MUST comment.

Adds one dummy CustomCssVariables property with no Theme Builder PR
link, to check that the Claude review posts the red MUST comment.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@tushardeepakts
tushardeepakts requested a review from a team as a code owner November 16, 2026 11:38

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a test-only CSS variable --ts-var-test-theme-builder-sync-color to CustomCssVariables in src/css-variables.ts. The reviewer pointed out that any new CSS variable added to CustomCssVariables must be synced with the Theme Builder, requiring a link to the corresponding Theme Builder PR or sync configuration before merging.

Comment thread src/css-variables.ts
Comment on lines +1956 to +1960
/**
* Test-only variable for checking the Theme Builder sync review rule
* (SCAL-266165). Do not merge.
*/
'--ts-var-test-theme-builder-sync-color'?: string;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

MUST: Any new CSS variable added to CustomCssVariables must be synced with the Theme Builder. Please provide a link to the corresponding Theme Builder PR or sync configuration in the pull request description before merging.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant