Skip to content

[SCAL-266165] Add Theme Builder sync rule to Claude PR review - #752

Open
tushardeepakts wants to merge 2 commits into
mainfrom
SCAL-266165-theme-builder-sync-review-rule
Open

tushardeepakts wants to merge 2 commits into
mainfrom
SCAL-266165-theme-builder-sync-review-rule

Conversation

@tushardeepakts

@tushardeepakts tushardeepakts commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

When a PR adds, removes or renames a CustomCssVariables property in src/css-variables.ts, the review agent now checks the PR for a linked Theme Builder PR and posts a red MUST comment if none is found. The check is non-blocking, last in priority, and never skipped.

Test PR: #753

image

When a PR adds, removes or renames a CustomCssVariables property in
src/css-variables.ts, the review agent now checks the PR for a linked
Theme Builder PR and posts a red MUST comment if none is found. The
check is non-blocking, last in priority, and never skipped.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@tushardeepakts
tushardeepakts requested a review from a team as a code owner November 16, 2026 11:29

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the review prompt instructions in .github/claude-review-prompt.md to introduce a mandatory check for syncing CSS variable changes with the Theme Builder repository. It details the requirements for linking a matching Theme Builder PR and how to format the review summary accordingly. The review feedback suggests simplifying the gh pr view command by omitting the explicit PR number, allowing the GitHub CLI to automatically detect the pull request associated with the current branch.

Comment thread .github/claude-review-prompt.md Resolved
@pkg-pr-new

pkg-pr-new Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@thoughtspot/visual-embed-sdk@752

commit: 446c0e8

gh pr view needs an explicit number in the review job: actions/checkout
leaves a detached merge commit, so branch-based PR lookup fails.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant