Repository navigation
chore(cleanup): remove dead chart options, the playground and legacy chat routes; contract retired DB objects - #10269
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 100 files
This PR changes a database schema or migrates data. Ultrareviews find 2.4x more serious bugs than standard reviews. Comment @cubic-dev-ai ultrareview to run one.
Turn on auto-fix | Re-trigger cubic
Contributor
[High impact] The PR appears safe to merge; no new actionable issues were found. SummaryRemoves unused chart options, the playground, legacy chat routes, and retired database objects.
|
Collaborator
Author
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
monitoring.serviceMonitoroption: neither the app nor realtime serves/metrics. Its schema key is kept as an ignored stub so older values files still validate.sharedStorage: the chart created PVCs that nothing mounted. A new guard fails the render whilesharedStorageis enabled with volumes, and tells the operator how to keep the PVCs before upgrading, since dropping the template would otherwise delete them. Chart bumped to 1.13.0.docker-compose.ollama.ymlas an overlay ondocker-compose.prod.yml, so it picks up the required secrets, Redis, cron and published images. The docs cover migrating from the old standalone stack without losing its database volume.@radix-ui/react-tabsdependency that only it used.ALLOW_PRIVATE_DATABASE_HOSTS. It now only logs a startup error pointing atEGRESS_ALLOWED_HOSTS/EGRESS_ALLOWED_IP_RANGES./api/copilot/chat/*into/api/mothership/chat/*, replacing the thin shims.v1/copilot/chat410 tombstone./api/copilot/chat/abortworking for one release through a Next rewrite, for tabs loaded before the move.waitlist, the legacy file-search index/segment tables and the legacy dispatch queue. The trigger is redefined first so it stops writing to the queue.organization.whitelabel_settingsand adds a contract-pending marker. The column itself is dropped after this release ships.Type of Change
Testing
check:migrations origin/stagingandcheck-pending-drop-tablespass.helm lint,helm unittest(123 tests), andhelm templateover every example and CI values file.docker compose -f docker-compose.prod.yml -f docker-compose.ollama.yml configfor each profile.check:api-validation:strict,check-route-verbs,check:api-contract-routes,check-explicit-any,check-source-conventions,check:test-patterns,check:comment-hygiene.Checklist
test-auditauthoring gate)