Skip to content

chore(cleanup): remove dead chart options, the playground and legacy chat routes; contract retired DB objects - #10269

Merged
waleedlatif1 merged 6 commits into
stagingfrom
chore/feature-cleanup
Nov 21, 2026
Merged

waleedlatif1 merged 6 commits into
stagingfrom
chore/feature-cleanup

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Remove the Helm monitoring.serviceMonitor option: neither the app nor realtime serves /metrics. Its schema key is kept as an ignored stub so older values files still validate.
  • Remove Helm sharedStorage: the chart created PVCs that nothing mounted. A new guard fails the render while sharedStorage is enabled with volumes, and tells the operator how to keep the PVCs before upgrading, since dropping the template would otherwise delete them. Chart bumped to 1.13.0.
  • Rewrite docker-compose.ollama.yml as an overlay on docker-compose.prod.yml, so it picks up the required secrets, Redis, cron and published images. The docs cover migrating from the old standalone stack without losing its database volume.
  • Remove the design playground page, and the emcn exports and @radix-ui/react-tabs dependency that only it used.
  • Remove the deprecated ALLOW_PRIVATE_DATABASE_HOSTS. It now only logs a startup error pointing at EGRESS_ALLOWED_HOSTS / EGRESS_ALLOWED_IP_RANGES.
  • Make the mothership chat routes canonical:
    • Move the real stream/stop/resources/abort handlers from /api/copilot/chat/* into /api/mothership/chat/*, replacing the thin shims.
    • Delete the unused copilot copies and the v1/copilot/chat 410 tombstone.
    • Keep /api/copilot/chat/abort working for one release through a Next rewrite, for tabs loaded before the move.
  • Migration 0468 contracts retired DB objects:
    • Drops waitlist, the legacy file-search index/segment tables and the legacy dispatch queue. The trigger is redefined first so it stops writing to the queue.
    • Drops six columns that were un-declared long ago.
    • Validates six NOT VALID constraints.
    • Drops the unused personal-token identity index concurrently.
    • Un-declares organization.whitelabel_settings and adds a contract-pending marker. The column itself is dropped after this release ships.

Type of Change

  • Chore / cleanup

Testing

  • Migration:
    • check:migrations origin/staging and check-pending-drop-tables pass.
    • drizzle generate is a no-op after the migration.
    • The 0018 script-migration integration test passes against a local Postgres.
  • Helm: helm lint, helm unittest (123 tests), and helm template over every example and CI values file.
  • Compose: docker compose -f docker-compose.prod.yml -f docker-compose.ollama.yml config for each profile.
  • Targeted vitest across chat routes, use-chat, security/egress, emcn and sim-setup.
  • Audits: check:api-validation:strict, check-route-verbs, check:api-contract-routes, check-explicit-any, check-source-conventions, check:test-patterns, check:comment-hygiene.
  • Full type-check, audits and the integration suites run in CI.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@waleedlatif1
waleedlatif1 requested a review from a team as a code owner November 21, 2026 01:50
@vercel

vercel Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Ignored Ignored Preview Nov 21, 2026 2:35am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 100 files

This PR changes a database schema or migrates data. Ultrareviews find 2.4x more serious bugs than standard reviews. Comment @cubic-dev-ai ultrareview to run one.

Turn on auto-fix | Re-trigger cubic

Comment thread helm/sim/templates/removed-values.yaml Resolved
Comment thread .github/CONTRIBUTING.md Resolved
Comment thread apps/sim/lib/core/config/env-flags.ts Resolved
@greptile-apps

greptile-apps Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[High impact] The PR appears safe to merge; no new actionable issues were found.

Summary

Removes unused chart options, the playground, legacy chat routes, and retired database objects.

  • Chat requests now use the mothership routes.
  • Helm no longer creates unused monitoring or storage resources.
  • The Ollama Compose file now extends the production stack.
  • The old private-database flag no longer grants access to private addresses.
  • The component playground page is removed.
  • Unused component-package parts are removed from the shared UI library.
  • The database migration retires unused tables and columns while deferring one column drop.
  • Supporting docs and generated records are updated without changing app behavior.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Client[Chat client] --> Canonical["/api/mothership/chat/*"]
  Old["Old /api/copilot/chat/abort"] --> Rewrite[Temporary rewrite]
  Rewrite --> Abort["/api/mothership/chat/abort"]
  Canonical --> Handlers[Chat handlers]
  Abort --> Stop[Abort run]
Loading

Reviews (2) · Last reviewed commit: "improvement(cleanup): drop dead folder p..." · Reviewed by Greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1
waleedlatif1 merged commit 287a110 into staging Nov 21, 2026
168 of 170 checks passed
@waleedlatif1
waleedlatif1 deleted the chore/feature-cleanup branch November 21, 2026 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant