Repository navigation
chore(mothership): take the worker's typed stream contract, own telemetry names in Sim, and rename go-era names to worker - #10273
waleedlatif1 wants to merge 7 commits into
Conversation
…y contracts, and rename go-era names to worker
…ite-only trace collector and dead _serviceCost output Recovery rows keep the goRoute key every deployed Sim parses, so a rollback or mixed-version deploy still takes over in-flight runs; workerRoute is the in-memory name only. Also removes TraceCollector and its span plumbing (nothing read it), the _serviceCost tool output no reader consumes, Go-era span data fallbacks (pending, tool_call_id), the Go-only billing replay live test, and takes the worker contract's removal of the async tool status by owning it in async-runs.
…ecovery key in one place, and simplify the stream contract types - Move the trace span, attribute, attribute-value, event and metric name tables out of generated/ into lib/mothership/observability/ as Sim-owned code; the worker no longer syncs them. CODEOWNERS keeps them with the mothership team. - StreamRecoveryConfigSchema reads the persisted goRoute key as workerRoute, and persistedStreamRecoveryConfig writes it back as goRoute, so no caller names the stored key. - Derive SyntheticFilePreviewEventEnvelope and EnvelopeToStreamEvent from MothershipStreamV1Envelope, drop a duplicate doc comment, and replace a nested ternary in applyStreamEvent with plain branches.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
[Medium impact] The changes since the previous review appear safe to merge. SummaryConsolidates stream readers around the worker’s typed contract, moves telemetry names into Sim, and renames Go-era code to worker.
Reviews (2) · Last reviewed commit: "test(mothership): compare the admitted r..." · Reviewed by Greptile |
There was a problem hiding this comment.
All reported issues were addressed across 194 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
…ted goRoute shape
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
mothership-stream-v1, so drift is a compile errorrequest/session/contract.tstypes every reader from the one v1 envelope; its per-type intersections and resource override are gonestructured_result/subagent_result, runresumed,checkpoint_pause.framesand the per-subagent resume fan-out it fed,compaction_done.data,session/trace, steeringcontent/messageId/mode, andgoTraceId.error.error/error.dataand session chat/title stay, because Sim emits them itselflib/mothership/observability/(mothership D118). Dead names are pruned, and the raw literals Sim emits now use the constantsworker:request/go/→request/worker/,fetchGo→fetchWorker,withIncomingGoSpan→withIncomingWorkerSpan, the testing mocks, and thesim → worker …span namesgoRoute, so older Sim builds keep reading new rows during a rolling deploy or rollback.recovery-config.tsis the only place that maps it toworkerRouteTraceCollector, the dead_serviceCostoutput (hosted-key spend is metered byrecordServiceCost), the Go-onlyreplay.live.test.ts, and stale CODEOWNERS pathsCompanion: simstudioai/mothership#997
Type of Change
Testing
tsc --noEmitclean,bun run lintcleanapp/api/mothership,lib/mothershipandlib/core: 4,909 passedcheck:api-validation:strictpassgoRoutewith noworkerRoute, a legacy row reads back, and a round trip worksChecklist