Repository navigation
improvement(ci): install e2e browser system packages from a per-image cache - #10258
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
[Medium impact] The PR appears safe to merge; no actionable issues remain from this review. SummaryThe PR caches Playwright system packages by runner image, lockfile, and suite group.
Reviews (6) · Last reviewed commit: "fix(e2e): start the markdown keyboard se..." · Reviewed by Greptile |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
680509d to
1f5ddd5
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
|
Measured on this PR's runs ("Browser install took Ns", timed inside
All eight warm installs came from the cache with no mirror access. The cold runs on this branch also showed the failure mode this removes: one browser-extension-access install took 438s. On #10251 a markdown-viewer job sat 19 minutes mid-download of
The cache only benefits PRs once staging has saved one: a cache saved on a PR is scoped to that PR. The first validation run on staging after merge seeds it. |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
…ompare settled chip screenshots
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
playwright install-depsapt-installs the browsers' system libraries on every e2e job: 181 packages / 126 MB for WebKit, throughapt-get updateand an Ubuntu mirror. When a mirror stalls, the job stalls with it. One markdown-viewer run spent 16 minutes in that wait before its first check (median run: 168s)install-playwright.shnow installs from a directory of cached.debfiles when one is given. A cold or incomplete cache falls back toinstall-depsand then stores what apt downloadedactions/cache, keyed by runner image (ImageOS-ImageVersion),bun.lock(the Playwright version) and grouphttp-e2e.shlogs how long the browser install took and whether it came from the cache, so the effect is visible in every job logdpkg -i, not apt: apt prefers a repository copy of a package whose version matches a cached file and tries to fetch itType of Change
Testing
Checklist
test-auditauthoring gate)