Repository navigation
fix(files): keep the reader's caret when the markdown editor settles - #10263
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The change appears safe to merge. SummaryPreserves an existing caret when the markdown editor settles.
No actionable issues were found in the changed code. Reviews (2) · Last reviewed commit: "fix(files): keep the reader's caret when..." · Reviewed by Greptile |
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getSelection().collapse) back to the original keyboard-only ArrowLeft + Shift+ArrowRight. In WebKit the programmatic caret did not hold, and the check failed on two of four runs after it merged. The check now waits for the selection to be non-empty instead of reading it onceType of Change
Testing
apps/sim/scripts/test-markdown-viewer-e2e.ts) exercises this path in Chromium and WebKit on this PRcheck:comment-hygieneChecklist
test-auditauthoring gate)