Skip to content

improvement(ci): turn off crash durability on throwaway CI postgres - #10251

Merged
waleedlatif1 merged 2 commits into
stagingfrom
ci/ci-postgres-durability
Nov 20, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
ci/ci-postgres-durability

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • HTTP e2e, e2e-production and desktop-live each run against a throwaway Postgres service. A new step turns off fsync and full_page_writes before migrations
  • packages/db/scripts/tune-ci-postgres.ts applies them with ALTER SYSTEM + reload (service containers take no -c flags). It fails unless a fresh session reports both off
  • synchronous_commit stays on. Asynchronous commit delays hint bits and VACUUM's all-visible marking until the WAL flush, which broke the index-only plan assertions in usage-analytics-plans.integration.ts on the first run of this PR. With fsync off that flush is free anyway
  • Integration shards are left as they were: they showed no gain (269s median on this PR vs 241s over 745 earlier shards)

Numbers

  • search-permissions large import upload: 197s → 163s (−17%); run step 212s → 173s
  • Tuning step: ≤1s per job

Type of Change

  • Improvement

Testing

  • actionlint, biome, type-check:scripts:esm via pre-push
  • The script checks its own result: the job fails if the settings don't apply
  • Full CI on this PR

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 20, 2026 8:54pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge; no actionable new issues were found.

Summary

Turns off fsync and full_page_writes before database setup in HTTP, production-browser, and desktop-live CI jobs.

  • CI test databases skip crash-durability disk writes.

Reviews (2) · Last reviewed commit: "fix(ci): keep synchronous_commit on and ..." · Reviewed by Greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 force-pushed the ci/ci-postgres-durability branch from fae0d61 to 0b0a777 Compare November 20, 2026 20:47
@waleedlatif1
waleedlatif1 merged commit 74eca43 into staging Nov 20, 2026
84 of 85 checks passed
@waleedlatif1
waleedlatif1 deleted the ci/ci-postgres-durability branch November 20, 2026 21:13

This branch was successfully deployed

1 active deployment
Preview — 0b0a7772 Deployed Nov 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant