Repository navigation
improvement(ci): turn off crash durability on throwaway CI postgres - #10251
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
[Low impact] The PR appears safe to merge; no actionable new issues were found. SummaryTurns off
Reviews (2) · Last reviewed commit: "fix(ci): keep synchronous_commit on and ..." · Reviewed by Greptile |
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
waleedlatif1
force-pushed
the
ci/ci-postgres-durability
branch
from
November 20, 2026 20:47
fae0d61 to
0b0a777
Compare
5 of 6 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fsyncandfull_page_writesbefore migrationspackages/db/scripts/tune-ci-postgres.tsapplies them withALTER SYSTEM+ reload (service containers take no-cflags). It fails unless a fresh session reports both offsynchronous_commitstays on. Asynchronous commit delays hint bits and VACUUM's all-visible marking until the WAL flush, which broke the index-only plan assertions inusage-analytics-plans.integration.tson the first run of this PR. Withfsyncoff that flush is free anywayNumbers
Type of Change
Testing
type-check:scripts:esmvia pre-pushChecklist
test-auditauthoring gate)