Repository navigation
improvement(ci): run the large permission import e2e beside organization search - #10225
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
[Medium impact] The PR appears safe to merge; no new actionable issues were found. SummaryMoves the large GitLab permission import into a parallel
Reviews (3) · Last reviewed commit: "fix(ci): select the permission import gr..." · Reviewed by Greptile |
5 of 6 tasks
Collaborator
Author
5 of 6 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test-gitlab-csv-permissions-e2e.tswithGITLAB_CSV_E2E_LARGE_IMPORT=1) out of theorganization-searche2e job and into a new parallelsearch-permissionsgroup. The test runs the same way it did before; nothing is skipped or loosened.e2e (organization-search)went from a 173s median to 408s (p95 752s), which made it the slowest job on every PR.ci:e2e-search-permissions), so changing the GitLab script only selects that group, and changing the org-search UI script only selectsorganization-search. The task also now depends onsim#ci:runtime, because the script runs the Sim CLI.Type of Change
Testing
scripts/ci-changes.test.tsis updated so the GitLab script selectssearch-permissions, and a change to a shared security package selects both groups. CI runs this file intest:scripts.Checklist
test-auditauthoring gate)