Skip to content

improvement(ci): run the large permission import e2e beside organization search - #10225

Merged
waleedlatif1 merged 2 commits into
stagingfrom
ci/speed-audit
Nov 20, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
ci/speed-audit

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Moved the 500,000-identity GitLab permission import proof (test-gitlab-csv-permissions-e2e.ts with GITLAB_CSV_E2E_LARGE_IMPORT=1) out of the organization-search e2e job and into a new parallel search-permissions group. The test runs the same way it did before; nothing is skipped or loosened.
  • The import uploads 700 parts one after another. Since it was added, e2e (organization-search) went from a 173s median to 408s (p95 752s), which made it the slowest job on every PR.
  • Gave the new group its own Turbo task (ci:e2e-search-permissions), so changing the GitLab script only selects that group, and changing the org-search UI script only selects organization-search. The task also now depends on sim#ci:runtime, because the script runs the Sim CLI.
  • The new group skips the Playwright install, since it never opens a browser.

Type of Change

  • Improvement (CI)

Testing

  • Audited 150 recent PR runs to find the cause: org-search's suite step went from about 100s to about 330s when the large import landed, and its tail went up to 900s.
  • scripts/ci-changes.test.ts is updated so the GitLab script selects search-permissions, and a change to a shared security package selects both groups. CI runs this file in test:scripts.
  • Local checks were left to CI on purpose.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@waleedlatif1
waleedlatif1 requested a review from a team as a code owner November 20, 2026 03:59
@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 20, 2026 4:09am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no new actionable issues were found.

Summary

Moves the large GitLab permission import into a parallel search-permissions CI group.

  • The GitLab permission import runs in its own CI group.

Reviews (3) · Last reviewed commit: "fix(ci): select the permission import gr..." · Reviewed by Greptile

Comment thread apps/sim/turbo.json Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1
waleedlatif1 merged commit 892d8d8 into staging Nov 20, 2026
87 checks passed
@waleedlatif1
waleedlatif1 deleted the ci/speed-audit branch November 20, 2026 04:22

This branch was successfully deployed

1 active deployment
Preview — 350410cd Deployed Nov 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant