Repository navigation
improvement(ci): cache Playwright browsers for e2e jobs - #10226
waleedlatif1 wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
[Low impact] The changes affect selected CI browser checks and their install logs. The PR appears safe to merge, with a non-blocking gap in cache coverage for Findings
SummaryAdds Playwright browser caching to HTTP and mobile jobs.
Reviews (1) · Last reviewed commit: "improvement(ci): cache Playwright browse..." · Reviewed by Greptile |
| - &resolve-playwright | ||
| name: Resolve the Playwright version | ||
| id: playwright | ||
| if: &browser-group contains(fromJSON('["assistant-actions","organization-search","markdown-viewer","workflow-code-ui","mobile"]'), matrix.group) || startsWith(matrix.group, 'browser-extension-') |
There was a problem hiding this comment.
The scim job calls start_browser_install people chromium and waits for it, but browser-group skips both new cache steps. It still downloads Chromium on every run. Add scim to the shared condition so this browser job also benefits from the cache.
| if: &browser-group contains(fromJSON('["assistant-actions","organization-search","markdown-viewer","workflow-code-ui","mobile"]'), matrix.group) || startsWith(matrix.group, 'browser-extension-') | |
| if: &browser-group contains(fromJSON('["scim","assistant-actions","organization-search","markdown-viewer","workflow-code-ui","mobile"]'), matrix.group) || startsWith(matrix.group, 'browser-extension-') |
|
Closing: the first run's timing line shows the browser download is 2-9s per job. The wait comes from Playwright's system-dependency step ( |
Summary
~/.cache/ms-playwrightfor the browser e2e groups (HTTP acceptance including SCIM, and mobile). The key is the Playwright version plus the browser set, so a version bump starts a fresh entry and old browser revisions never pile up.checks.yml, so it seeds the cache that PRs restore. PR and fork runs write only to their own scope.install-playwright.shnow reports how long system dependencies and browsers each took, andhttp-e2e.shprints that line, so the remaining install cost shows up in every job log.Type of Change
Testing
checks.yml.Checklist
test-auditauthoring gate)