Repository navigation
feat(mcp): enable code mode for every caller and remove the mcp-code-mode flag - #10223
Merged
Merged
Conversation
…mode flag - Every Sim MCP caller gets execute_read_code and execute_write_code; the sandbox owner key comes from the principal (person, or workspace for workspace keys) - Default program timeout is 45s, under the 60s MCP client request default - A null query value is left out, so the last page's null cursor ends paging - The scope pre-check trims the operation name like the call tools do - Docs state the 256 KB per-call input limit and drop the beta note
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[High impact] The PR appears safe to merge, with no new actionable issues found. SummaryMakes MCP code mode available to every authenticated caller and removes the feature flag.
No new actionable issues were found. Checks were based on source review; no tests were run during this review. Reviews (2) · Last reviewed commit: "fix(mcp): bound a code-mode run by one d..." · Reviewed by Greptile |
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
5 of 6 tasks
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcp-code-modeflag: every Sim MCP caller getsexecute_read_codeandexecute_write_code, with the code-mode instructions always ininitializequeryacceptsnulland leaves it out, socursor: page.nextCursorends paging instead of failing the callType of Change
Testing
code-mode.integration.ts(real Postgres + isolate pool): 12/12. New: a workspace API key lists and runs programs; a misplaced input key fails withINVALID_CALLinstead of being dropped; paging passes the null cursor straight throughnullfrom the query schema fails the paging test; removing.strict()from the request schema fails the misplaced-key testcheck:comment-hygiene,check:test-patterns,check:utils, docscontent:verify-compatibilityChecklist
test-auditauthoring gate)