Skip to content

fix(mcp): word the code-mode deadline timeout like any other timeout - #10227

Merged
waleedlatif1 merged 1 commit into
stagingfrom
waleed/mcp-code-mode-timeout-message
Nov 20, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
waleed/mcp-code-mode-timeout-message

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • The whole-run deadline from feat(mcp): enable code mode for every caller and remove the mcp-code-mode flag #10223 fires about a second before the isolate's own timeout result reaches the host, so it ends every timed-out run, not only ones that queued for a sandbox
  • Its message claimed the time included waiting for a sandbox, which is wrong for a run that never queued; it now reads The program did not finish within <n>ms.
  • Fix the grace constant's comment, which said a run that never queued ends with the isolate's TimeoutError

Type of Change

  • Bug fix

Testing

  • Seen live on staging: a program looping past a 3s timeout returned the queue wording without ever queuing
  • code-mode.integration.ts asserts the error name (TimeoutError), unchanged

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 20, 2026 4:31am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This wording-only change appears safe to merge.

Summary

Updates code-mode timeout wording without changing when runs stop.

  • Code-mode timeouts describe the program limit without implying sandbox wait time counts.

Reviews (2) · Last reviewed commit: "fix(mcp): word the code-mode deadline ti..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 8d37e10 into staging Nov 20, 2026
63 checks passed
@waleedlatif1
waleedlatif1 deleted the waleed/mcp-code-mode-timeout-message branch November 20, 2026 04:40

This branch was previously deployed

1 inactive deployment
Preview — 9c78f916 Deployed Nov 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant