Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions .github/workflows/release-candidate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -713,13 +713,16 @@ jobs:
path: |
~/.cargo/registry
~/.cargo/git
target
key: registry-stack-release-clients-go-1.24.4-zig-0.12.1-glibc-2.17-${{ matrix.asset }}-${{ hashFiles('rust-toolchain.toml', 'Cargo.lock', 'release/requirements/maturin-1.9.6.txt', 'release/scripts/zig-glibc-compiler', 'release/scripts/build-linux-python-client', 'release/scripts/build-linux-node-client', 'release/scripts/assemble-registry-client-wheel.py', 'release/scripts/sync-registry-client-node.py', 'crates/registry-discovery-client-node/package-lock.json', 'crates/registry-evidence-client-node/package-lock.json', 'crates/registry-relay-client-node/package-lock.json', 'crates/registry-breg-client-node/package-lock.json', 'crates/registry-casework-client-node/package-lock.json', 'crates/registry-stack-client-node/package-lock.json') }}
target/release-client-python
target/release-client-node
key: registry-stack-release-isolated-clients-go-1.24.4-zig-0.12.1-glibc-2.17-${{ matrix.asset }}-${{ hashFiles('.github/workflows/release-candidate.yml', 'rust-toolchain.toml', 'Cargo.lock', 'release/requirements/maturin-1.9.6.txt', 'release/scripts/zig-glibc-compiler', 'release/scripts/build-linux-python-client', 'release/scripts/build-linux-node-client', 'release/scripts/assemble-registry-client-wheel.py', 'release/scripts/sync-registry-client-node.py', 'crates/registry-discovery-client-node/package-lock.json', 'crates/registry-evidence-client-node/package-lock.json', 'crates/registry-relay-client-node/package-lock.json', 'crates/registry-breg-client-node/package-lock.json', 'crates/registry-casework-client-node/package-lock.json', 'crates/registry-stack-client-node/package-lock.json') }}
restore-keys: |
registry-stack-release-clients-go-1.24.4-zig-0.12.1-glibc-2.17-${{ matrix.asset }}-
registry-stack-release-isolated-clients-go-1.24.4-zig-0.12.1-glibc-2.17-${{ matrix.asset }}-

- name: Build Python client wheels
shell: bash
env:
CARGO_TARGET_DIR: ${{ github.workspace }}/target/release-client-python
run: |
set -euo pipefail
rustup toolchain install 1.95.0 --profile minimal
Expand Down Expand Up @@ -873,6 +876,8 @@ jobs:

- name: Build Node client packages
shell: bash
env:
CARGO_TARGET_DIR: ${{ github.workspace }}/target/release-client-node
run: |
set -euo pipefail
IFS=. read -r client_major client_minor client_patch <<<"${CLIENT_VERSION}"
Expand Down
34 changes: 34 additions & 0 deletions release/scripts/test_release_workflow_structure.py
Original file line number Diff line number Diff line change
Expand Up @@ -854,6 +854,18 @@ def test_builds_and_smokes_stable_native_client_packages(self) -> None:
)
cache_key = cargo_cache["with"]["key"]
restore_key = cargo_cache["with"]["restore-keys"]
self.assertEqual(
cargo_cache["with"]["path"].splitlines(),
[
"~/.cargo/registry",
"~/.cargo/git",
"target/release-client-python",
"target/release-client-node",
],
)
self.assertIn("release-isolated-clients", cache_key)
self.assertIn("release-isolated-clients", restore_key)
self.assertIn(".github/workflows/release-candidate.yml", cache_key)
self.assertIn("go-1.24.4", cache_key)
self.assertIn("go-1.24.4", restore_key)
self.assertIn("zig-0.12.1-glibc-2.17", cache_key)
Expand All @@ -877,6 +889,28 @@ def test_builds_and_smokes_stable_native_client_packages(self) -> None:
self.assertIn("expected_wheels=2", wheel)
self.assertIn("--require-hashes --only-binary=:all:", wheel)
self.assertIn("release/requirements/maturin-1.9.6.txt", wheel)
python_step = next(
step
for step in clients["steps"]
if step.get("name") == "Build Python client wheels"
)
node_step = next(
step
for step in clients["steps"]
if step.get("name") == "Build Node client packages"
)
self.assertEqual(
python_step["env"]["CARGO_TARGET_DIR"],
"${{ github.workspace }}/target/release-client-python",
)
self.assertEqual(
node_step["env"]["CARGO_TARGET_DIR"],
"${{ github.workspace }}/target/release-client-node",
)
self.assertNotEqual(
python_step["env"]["CARGO_TARGET_DIR"],
node_step["env"]["CARGO_TARGET_DIR"],
)
node = step_run(document, "clients", "Build Node client packages")
self.assertNotIn("--use-napi-cross", node)
self.assertIn(
Expand Down
Loading