fix(release): isolate native client build caches - #1315
Merged
Merged
Conversation
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The candidate builds Python wheels and Node bindings sequentially in the release profile. Their Zig compiler wrappers have different paths, so sharing Cargo's target directory makes the Node build reconfigure AWS-LC-FIPS inside Python's existing CMake cache and fail.
Give each language its own target directory while retaining reuse across products within that language. Restrict the cache paths and use a fresh namespace so an older shared target tree cannot be restored into this recipe.
Evidence
python3 -m unittest release/scripts/test_release_workflow_structure.py: 56 tests passed, including target-directory isolation and cache migration assertions.actionlint: passed.python3 release/scripts/check-gates-inventory.py: passed, 213 gates.git diff --check: passed.Notes
This changes build-cache ownership only. Compiler versions, release profiles, dependencies, FIPS selection, and artifact verification are unchanged. The existing rehearsal builds Node independently and does not exercise this sequential-build failure.
DCO
Signed-off-bytrailer.