Skip to content

fix(release): isolate native client build caches - #1315

Merged
jeremi merged 1 commit into
mainfrom
fix/v033-client-cache-isolation
Sep 22, 2026
Merged

jeremi merged 1 commit into
mainfrom
fix/v033-client-cache-isolation

Conversation

@jeremi

@jeremi jeremi commented Sep 22, 2026

Copy link
Copy Markdown
Member

Summary

The candidate builds Python wheels and Node bindings sequentially in the release profile. Their Zig compiler wrappers have different paths, so sharing Cargo's target directory makes the Node build reconfigure AWS-LC-FIPS inside Python's existing CMake cache and fail.

Give each language its own target directory while retaining reuse across products within that language. Restrict the cache paths and use a fresh namespace so an older shared target tree cannot be restored into this recipe.

Evidence

  • python3 -m unittest release/scripts/test_release_workflow_structure.py: 56 tests passed, including target-directory isolation and cache migration assertions.
  • Pinned actionlint: passed.
  • python3 release/scripts/check-gates-inventory.py: passed, 213 gates.
  • git diff --check: passed.
  • The failed candidate's Python wheels and smoke passed before Node failed in AWS-LC-FIPS CMake reconfiguration. This change has not yet completed a real candidate build; the next candidate will exercise the corrected sequence on all supported rows.

Notes

This changes build-cache ownership only. Compiler versions, release profiles, dependencies, FIPS selection, and artifact verification are unchanged. The existing rehearsal builds Node independently and does not exercise this sequential-build failure.

DCO

  • Every commit includes a Signed-off-by trailer.
  • I reviewed the submitted changes and am responsible for the contribution.

Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 22, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-22T12:49:38.687092Z d0ccd00 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jeremi
jeremi merged commit 575a9f5 into main Sep 22, 2026
43 checks passed
@jeremi
jeremi deleted the fix/v033-client-cache-isolation branch September 22, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant