Repository navigation
Adopt RuboCop, add Snyk scan and remove Codacy #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jguz-pubnub
wants to merge
15
commits into
master
Choose a base branch
from
ruby-rubocop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
ebacdfc
Remove Codacy coverage reporter and references
jguz-pubnub bd96895
Configure RuboCop with generated todo file for existing offenses
jguz-pubnub cc9ea1e
Run RuboCop in CI on every push and pull request
jguz-pubnub 7fc80de
Run RuboCop as part of the Validations workflow
jguz-pubnub 80dcb72
Unify Validations workflow triggers and concurrency
jguz-pubnub 3443c96
Run Validations on push only
jguz-pubnub 2100032
Remove explanatory comment from RuboCop config
jguz-pubnub 1f2dcf8
Enable new RuboCop cops and add Snyk vulnerability scan
jguz-pubnub b2c59a3
Run vulnerability scan on master only
jguz-pubnub d4a1985
.rubocop.yml
jguz-pubnub f1a222c
Merge branch 'master' into ruby-rubocop
jguz-pubnub f88a0f4
access_manager.rb
jguz-pubnub 5e53b74
vulnerability-scan.yml
jguz-pubnub 72af0aa
vulnerability-scan.yml
jguz-pubnub 5b0b65d
Add CodeQL scan, drop Code Climate, fix ReDoS in message counts
jguz-pubnub File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| name: CodeQL | ||
| on: | ||
| push: | ||
| branches: [master] | ||
| pull_request: | ||
| workflow_dispatch: | ||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| analyze: | ||
| name: CodeQL | ||
| runs-on: | ||
| group: organization/Default | ||
| permissions: | ||
| contents: read | ||
| security-events: write | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
| - name: Initialize CodeQL | ||
| uses: github/codeql-action/init@33d7b85da1a04171e211befe2c739303b9a4c066 # v4.39.3 | ||
| with: | ||
| languages: ruby | ||
| build-mode: none | ||
| - name: Analyze | ||
| uses: github/codeql-action/analyze@33d7b85da1a04171e211befe2c739303b9a4c066 # v4.39.3 | ||
| with: | ||
| category: /language:ruby |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| name: Vulnerability scan | ||
| on: | ||
| push: | ||
| branches: | ||
| - master | ||
| - main | ||
|
|
||
| jobs: | ||
| security: | ||
| runs-on: | ||
| group: organization/Default | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
| - name: Run Snyk monitor for vulnerabilities | ||
| run: snyk monitor --org=sdk --file=Gemfile.lock | ||
| env: | ||
| SNYK_TOKEN: ${{ secrets.SNYK_SDK_TOKEN }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These offenses in
.rubocop-todo.ymlare technical debt and should be fixed over time. The codebase should be improved gradually, and because of the scope of the changes, this PR does not cover that.