Skip to content

Adopt RuboCop, add Snyk scan and remove Codacy - #184

Open
jguz-pubnub wants to merge 15 commits into
masterfrom
ruby-rubocop
Open

jguz-pubnub wants to merge 15 commits into
masterfrom
ruby-rubocop

Conversation

@jguz-pubnub

@jguz-pubnub jguz-pubnub commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

ci: adopt RuboCop (CI validation, .rubocop.yml, .rubocop_todo.yml) and remove Codacy
ci: add a Vulnerability scan workflow (Snyk monitor on master/main)
ci: add a CodeQL workflow
ci: remove the unused .codeclimate.yml
fix: fix a polynomial regex flagged by CodeQL in MessageCounts#parse_timetokens

jguz-pubnub and others added 6 commits November 18, 2026 11:52
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@pubnub-snyk-universal-prd

pubnub-snyk-universal-prd Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Comment thread .rubocop.yml
@@ -1,4 +1,8 @@
inherit_from: .rubocop_todo.yml

@jguz-pubnub jguz-pubnub Nov 18, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These offenses in .rubocop-todo.yml are technical debt and should be fixed over time. The codebase should be improved gradually, and because of the scope of the changes, this PR does not cover that.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@jguz-pubnub jguz-pubnub changed the title Adopt RuboCop and remove Codacy Adopt RuboCop, add Snyk scan and remove Codacy Nov 18, 2026
jguz-pubnub and others added 7 commits November 18, 2026 12:52
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
- Add CodeQL workflow (Ruby) on pull requests and pushes to master
- Remove the unused .codeclimate.yml
- Replace a polynomial regex in MessageCounts#parse_timetokens with
  split(',').map(&:strip), as flagged by CodeQL

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants