Repository navigation
perf(component-build): save cache mounts only when lockfiles change - #403
Merged
Merged
Conversation
JesperTerkelsen
marked this pull request as ready for review
November 15, 2026 06:21
JesperTerkelsen
requested review from
prasad-manu
and removed request for
a team
November 15, 2026 06:21
brroMonta
approved these changes
Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Since #402, every S3-cached ARC image build extracts and uploads its Dockerfile cache mounts, which costs more than the faster compile it buys. This goes back to saving them only when the lockfiles change, and keeps the cache folder outside the checkout.
Decisions: give up the fresh compile cache inside Docker
Verified: per-commit key made infra-portal's build job ~1 min slower than no cache
go build6.8 s (was ~130 s), but restore + inject 67 s and extract + upload 135 s; build job 4m16s.actionlintpasses.Gaps
Thermo-nuclear review: no findings
Review of
17a268bNo findings.
component-build.yml: the key drops only the S3-only suffix; path, restore key and scratch dir stay as perf(component-build): keep cache mounts out of the checkout, save them every S3 build #402 left them, so both backends share one key shape again.CLAUDE.md: new dated entry with the measurements; the 2026-11-14 entry is marked as reverted rather than rewritten.