Repository navigation
feat(component-build): accept a prebuilt artifact and let callers skip cache mounts - #404
Merged
Merged
Conversation
JesperTerkelsen
marked this pull request as ready for review
November 15, 2026 06:30
JesperTerkelsen
requested review from
tobias0106
and removed request for
a team
November 15, 2026 06:30
brroMonta
approved these changes
Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Lets a repo compile on the runner, with a compile cache kept on the runner side, and hand the result to the image build, instead of compiling inside Docker. Callers that don't set the two new inputs build exactly as before.
Decisions: the artifact lands in the build context root, and the caller opts out of cache mounts itself
prebuilt-artifactdownloads a named artifact from an earlier job of the same run into the checkout beforedocker build; the DockerfileCOPY --chmods it, since artifacts drop file modes.dockerfile-cache-mounts: falseskips the restore, inject and save of the Dockerfile's cache mounts. On infra-portal they cost ~70 s to load and, when saved, ~135 s to extract and upload, which beat the compile time they saved (run).deploy-generic-v2.ymlforwards the inputs, the entry point infra-portal uses; the other deploy workflows can follow when a caller needs them (not discussed).Verified: actionlint passes
actionlinton both changed workflows passes. First real run is infra-portal's PR that uses it.Gaps
@main.Thermo-nuclear review: no findings
Review of
4ede609No findings.
component-build.yml: one input gates all three cache-mount steps with the same condition they already had; the download step runs only when an artifact is named, so existing callers' steps are unchanged.deploy-generic-v2.yml: forwards both inputs with the same defaults ascomponent-build.yml.