Skip to content

Add redundant algorithm - #4284

Merged
beutlich merged 1 commit into
modelica:masterfrom
HansOlsson:AddAlgo
Jan 29, 2024
Merged

Add redundant algorithm#4284
beutlich merged 1 commit into
modelica:masterfrom
HansOlsson:AddAlgo

Conversation

@HansOlsson

@HansOlsson HansOlsson commented Jan 26, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

The recently merged PR #3919 caused a regression in released versions of Dymola, so thus it would be good to have this work-around for the regression included in the release - it's not a new feature. (I'm a bit surprised that it wasn't detected in testing.)

This work-around should be harmless in itself.
(Obviously Dymola will be improved.)

@HansOlsson HansOlsson added this to the MSL4.1.0 milestone Jan 26, 2024
@HansOlsson

HansOlsson commented Jan 26, 2024

Copy link
Copy Markdown
Contributor Author

@GallLeo I'm not sure if it was detected, it is related to:
https://www.ltx.de/download/MA/Compare_MSL_v4.1.0/Testruns/Dymola/ModelicaTest/_report/ModelicaTest.Math.TestBooleanFunctions/testcase_report.html
Basically these three functions will sometimes fail and/or fail to inline.

@beutlich

beutlich commented Jan 26, 2024

Copy link
Copy Markdown
Member

I can only guess the regression test of ModelicaTest.Math.TestBooleanFunctions (as confirmed by @Harisankar-Allimangalath in #3919 (comment)) was not run in Dymola.

@beutlich beutlich changed the title Add Redundant Algorithm Add redundant algorithm Jan 27, 2024
@beutlich beutlich added L: Math Issue addresses Modelica.Math V: 4.1.0-dev Issue originates in MSL v4.1.0-dev (and is not present in earlier releases) labels Jan 27, 2024
@beutlich
beutlich enabled auto-merge (squash) January 27, 2024 11:04
henrikt-ma
henrikt-ma approved these changes Jan 29, 2024
View reviewed changes

@henrikt-ma henrikt-ma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Looking forward to Dymola being improved so that we no longer need these!

maltelenz
maltelenz approved these changes Jan 29, 2024
View reviewed changes

@maltelenz maltelenz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no harm in small changes like these to make it work in more tools, when the tools have plans to fix their root cause in the longer term (which is clearly the case here).

@beutlich
beutlich merged commit d156b9b into modelica:master Jan 29, 2024
@HansOlsson

HansOlsson commented Jan 29, 2024

Copy link
Copy Markdown
Contributor Author

@Harisankar-Allimangalath can you back-port this to maint/4.1.0?

@Harisankar-Allimangalath Harisankar-Allimangalath mentioned this pull request Jan 29, 2024
Closed
@beutlich
beutlich removed the request for review from GallLeo January 29, 2024 09:41
maltelenz pushed a commit to maltelenz/ModelicaStandardLibrary that referenced this pull request Jan 29, 2024
@HansOlsson @maltelenz
Add redundant algorithm (modelica#4284)
0c750c7 
(cherry picked from commit d156b9b)
@maltelenz maltelenz mentioned this pull request Jan 29, 2024
Merged
@beutlich beutlich removed this from the MSL4.1.0 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maltelenz maltelenz maltelenz approved these changes
@henrikt-ma henrikt-ma henrikt-ma approved these changes

Assignees

No one assigned

Labels

L: Math Issue addresses Modelica.Math V: 4.1.0-dev Issue originates in MSL v4.1.0-dev (and is not present in earlier releases)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@HansOlsson @beutlich @maltelenz @henrikt-ma