Skip to content

Add algo - #4289

Closed
Harisankar-Allimangalath wants to merge 10 commits into
modelica:maint/4.1.0from
HansOlsson:AddAlgo
Closed

Harisankar-Allimangalath wants to merge 10 commits into
modelica:maint/4.1.0from
HansOlsson:AddAlgo

Conversation

@Harisankar-Allimangalath

Copy link
Copy Markdown
Contributor

Back port #4284

@maltelenz maltelenz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a lot more than the change in #4284 in this.

@beutlich beutlich left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please cherry-pick the relevant changes only!

@Harisankar-Allimangalath

Copy link
Copy Markdown
Contributor Author

@beutlich I shall do the cherry pick .

@Harisankar-Allimangalath

Copy link
Copy Markdown
Contributor Author

@beutlich I am not authorized to merge or do cherry pick .

image

@HansOlsson

Copy link
Copy Markdown
Contributor

@beutlich I am not authorized to merge or do cherry pick .

image

@beutlich meant that you cherry-pick changes to this PR-branch (not directly to maint/4.1.0); and I can't see anything preventing that.

@Harisankar-Allimangalath

Copy link
Copy Markdown
Contributor Author

@HansOlsson @beutlich my assumption is that this PR-Branch already contains the changes we want and is already pushed to master , so I cherry-pick those commits from this branch to the master and then add it to this maint\4.1.0 branch. right ?

@maltelenz

Copy link
Copy Markdown
Contributor

@Harisankar-Allimangalath you need to create a new branch with only the commit(s) you want to include.

I created an alternative pull request #4290 that can replace this.

@maltelenz

Copy link
Copy Markdown
Contributor

Replaced by #4290 . Closing.

@maltelenz maltelenz closed this Jan 29, 2024
@beutlich beutlich added the invalid Invalid issue label Jan 29, 2024
@beutlich beutlich added this to the never milestone Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid Invalid issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants