Skip to content

docs(es): mirror English changes that landed after the Spanish docs base - #8633

Merged
lidge-jun merged 2 commits into
devfrom
fix/es-docs-parity-after-7559
Nov 13, 2026
Merged

lidge-jun merged 2 commits into
devfrom
fix/es-docs-parity-after-7559

Conversation

@lidge-jun

Copy link
Copy Markdown
Owner

Summary

dev currently fails tests/ci-workflows/docs-spanish-localization.test.ts ("keeps executable examples and frontmatter in the current English shape"). #7559 (Spanish docs, baa66c293a) was last merged with dev at ad3eb91895; English doc changes that landed afterwards were never mirrored into docs-site/src/content/docs/es/, so the parity test now fails on every PR's test shard.

This mirrors those English changes into Spanish:

Docs-only; no runtime change. A complete prose-parity audit of every English page changed since ad3eb91895 (45 pages) is follow-up work; this PR restores the structural parity the test enforces for the pages that broke it.

Verification

Synthetic HOME/TMPDIR, frozen installs at root, gui/ and docs-site/, based on dev f3d08ea502:

  • bun test --timeout 30000 tests/ci-workflows/docs-spanish-localization.test.ts on dev: 29 pass / 1 fail (red first); after this change 30 pass / 0 fail.
  • bun test --timeout 30000 tests/ci-workflows/docs*.test.ts: 419 pass / 0 fail across 17 files.
  • bun run privacy:scan passed; cd docs-site && bun run build passed (748 pages, 111,764 internal links); git diff --check passed.
  • NOT RUN locally: full root suite (docs-only change; hosted CI runs the test shards).

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner November 13, 2026 03:20
@coderabbitai

coderabbitai Bot commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 3 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between f3d08ea and d17f852.

Files selected for processing: 4

  • docs-site/src/content/docs/es/guides/remote-link.md
  • docs-site/src/content/docs/es/reference/cli/lifecycle.md
  • docs-site/src/content/docs/es/reference/cli/providers-accounts.md
  • docs-site/src/content/docs/es/reference/management-api.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T03:22:12.842500Z d17f852 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Nov 13, 2026
@lidge-jun

Copy link
Copy Markdown
Owner Author

Maintainer judgment — merge of #8633 at d17f852b73449f01937b6be1e0f9f4a1cce3a248

Value. Restores a green dev: docs-spanish-localization.test.ts failed on dev (29/1 at f3d08ea502, reproduced by the reviewer) because English doc changes after #7559's base were not mirrored into es/. This affects every PR's test shard.

UX change. Spanish readers get the current Remote Link options/journal, verified Windows stop, and xAI device-code login text. No other locale or runtime change.

Existing-user regression risk. None (four Spanish docs files only).

Windows impact. None at runtime; the Spanish lifecycle page now documents the verified Windows stop path that #8573 shipped.

Review. Fresh independent review PASS on this exact head (meaning-level comparison with the English sources and dev commits 600939d, d1f36ed, 6df43d5); docs tests 419/0, localization 30/0, privacy scan passed; all required checks green. A full prose-parity audit of every English page changed since ad3eb91 remains follow-up work.

@lidge-jun
lidge-jun merged commit 9532563 into dev Nov 13, 2026
27 checks passed
@lidge-jun
lidge-jun deleted the fix/es-docs-parity-after-7559 branch November 13, 2026 03:23
lidge-jun added a commit to harshav167/opencodex that referenced this pull request Nov 13, 2026
…rging dev

Co-authored-by: Harsha Vardhan <harsha@ansl.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant