Skip to content

docs(es): mirror English changes that landed after the previous parity fix - #8648

Merged
lidge-jun merged 1 commit into
devfrom
fix/es-docs-parity-2
Nov 13, 2026
Merged

lidge-jun merged 1 commit into
devfrom
fix/es-docs-parity-2

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Nov 13, 2026 •

Copy link
Copy Markdown
Owner

Summary

dev fails tests/ci-workflows/docs-spanish-localization.test.ts again ("keeps executable examples and frontmatter in the current English shape", troubleshooting/update-failed.md): #8331 (6788d42242) added pnpm global-store guidance to the English page without updating es/. Since #7559 the Spanish parity test runs in every PR's test shard, so this blocks unrelated PRs.

This mirrors the missing English changes since the previous parity fix (#8633, base f3d08ea502):

The other English pages changed since f3d08ea502 were checked and already in sync in es/ (codex-integration, google-vertex, providers, sub-agent-surface, subagent-v1-default, reference/cli, cli/agents, configuration/account-auto-pause, agents, providers). Docs-only.

Reminder for other lanes: any PR that changes an English page under docs-site/src/content/docs/ with a Spanish counterpart must update es/ in the same PR, or the parity test fails.

Verification

Synthetic HOME/TMPDIR, frozen installs at root, gui/ and docs-site/, based on dev 0f3286c375 (merges cleanly with current dev):

  • Localization test on dev: 29 pass / 1 fail (red first); after this change 30 pass / 0 fail.
  • bun test --timeout 30000 tests/ci-workflows/docs*.test.ts: 419 pass / 0 fail.
  • bun run privacy:scan passed; cd docs-site && bun run build passed (766 pages); git diff --check passed.
  • NOT RUN locally: full root suite (docs-only change; hosted CI runs the test shards).

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Summary by CodeRabbit

  • Documentation
    • Clarified that on Windows, traffic metrics may count an entire request body as sent even when Home has read only part of it.
    • Added Spanish troubleshooting guidance for failed updates with global pnpm 11 or 12, including store verification, common causes, and steps to update pnpm and restart the proxy. The guidance also explains when the updater stops and whether it reverts changes.

@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner November 13, 2026 04:57
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T04:58:56.701947Z d9d5507 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Nov 13, 2026
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The PR updates two Spanish documentation topics: Windows traffic metrics in the Remote Link guide and pnpm installation checks and recovery in the update troubleshooting guide.

Changes: Windows traffic metrics

Layer / File(s) Summary
Windows write accounting
docs-site/src/content/docs/es/guides/remote-link.md
The traffic-metrics guidance notes that Windows may accept a large body in one write. A Windows Child may therefore count the full body as sent before Home has read it all.

pnpm update troubleshooting

Layer / File(s) Summary
Store verification and recovery
docs-site/src/content/docs/es/troubleshooting/update-failed.md
The new section describes the global-store check for pnpm 11 and 12, when the updater stops, common verification failures, and the documented update and proxy restart steps.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Possibly related issues

Possibly related PRs

  • lidge-jun/opencodex#8627: That PR updates the English Remote Link guide with the Windows write behavior also described in this PR’s Spanish guide.

Suggested labels: documentation

Suggested reviewers: federicorv25

Merge Risk: Minimal · up to d9d55

This updates Spanish documentation to match the English pages. It has no runtime effect, and the author reports the parity test, docs tests and site build passing. It is safe to merge.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "docs(es): mirror English changes that landed after the previous parity fix" matches the main change. The PR updates two Spanish documentation pages (es/troubleshooting/update-failed.md and …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "docs(es): mirror English changes that landed after the previous parity fix" matches the main change. The PR updates two Spanish documentation pages (es/troubleshooting/update-failed.md and es/guides/remote-link.md) so they match English pages changed since the previous parity fix. The title is short, specific, and names the language scope (es) and the purpose (parity with English). It does not name the two files, but the task says the title need not cover every detail.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between be429e3 and d9d5507.

Files selected for processing: 2

  • docs-site/src/content/docs/es/guides/remote-link.md
  • docs-site/src/content/docs/es/troubleshooting/update-failed.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

@lidge-jun

Copy link
Copy Markdown
Owner Author

Maintainer judgment — merge of #8648 at d9d5507cd63d11dca1d3a2fa0c2ecf082f452adb

Value. Restores a green dev: docs-spanish-localization.test.ts failed on dev (29/1 at be429e3ae4, reproduced by the reviewer) because #8331 changed English troubleshooting/update-failed.md without es/.

UX change. Spanish readers get the pnpm global-store verification/recovery commands and the current Remote Link line. No runtime change.

Existing-user regression risk. None (two Spanish docs files).

Windows impact. None.

Review. Fresh independent review PASS on this exact head, including the localization test on the actual merge with current dev (30/0); docs tests 419/0; privacy scan passed; Codex review completed with no findings; CodeRabbit: no actionable comments; all 27 checks green.

@lidge-jun
lidge-jun merged commit 741d4d4 into dev Nov 13, 2026
31 checks passed
@lidge-jun
lidge-jun deleted the fix/es-docs-parity-2 branch November 13, 2026 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant