docs: add evidence-gated sprint QA checklist - #1993
groupthinking wants to merge 4 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository: groupthinking/EventRelay/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches. Re-running this action after a short time may resolve the issue. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
|
@copilot resolve the merge conflicts in this pull request |
There was a problem hiding this comment.
🟡 Changes recommended
Several commands do not inspect the intended evidence or reference a nonexistent test.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds an evidence-gated QA checklist for sprint review without authorizing production actions.
Changes:
- Maps landing, authentication, security, and hygiene checks to evidence.
- Separates local verification from remote prerequisites.
- Defines reviewer recordkeeping requirements.
File summaries
| File | Description |
|---|---|
docs/SPRINT_QA_CHECKLIST.md |
Adds the sprint QA checklist and evidence boundaries. |
Review details
Suppressed comments (3)
docs/SPRINT_QA_CHECKLIST.md:50
- This substitute refers to a local Playwright Home test that does not exist, so reviewers cannot perform the documented fallback. Point to the manual Home checks above unless a real Playwright spec is added.
| Preview-dependent end-to-end check | A ready Vercel Preview for the current PR head, followed by the PR’s E2E job completing against that preview. | Run the local Playwright Home test. Record that it is local-only evidence. |
docs/SPRINT_QA_CHECKLIST.md:59
- This status paragraph is already stale: PR #1984 is no longer a draft, and GitHub currently reports it as non-mergeable due to conflicts in addition to the failed Vercel/E2E evidence. Avoid freezing mutable check and merge state into a durable checklist; require reviewers to inspect the current PR state instead.
Draft [PR #1984](https://github.com/groupthinking/EventRelay/pull/1984) has passing build, test, lint, security, dependency-review, and CodeQL checks recorded by GitHub. It also has failed Vercel and E2E checks, so it remains **not ready for merge** until the remote preview and E2E failures are resolved or explicitly dispositioned by the repository owners.
docs/SPRINT_QA_CHECKLIST.md:70
- The reference title hard-codes #1984 as a draft even though the linked PR is currently open and non-draft. Use a status-neutral label so the reference remains accurate as the PR progresses.
[2]: https://github.com/groupthinking/EventRelay/pull/1984 "Draft Google sign-in retry pull request"
- Files reviewed: 1/1 changed files
- Comments generated: 6
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| | Check | Exact evidence command or observation | Pass condition | | ||
| |---|---|---| | ||
| | Home copy and checkout boundaries | Run the focused [Home sell-surface test](https://github.com/groupthinking/EventRelay/blob/main/apps/web/src/lib/__tests__/home-sell-surface.test.ts), [Studio handoff test](https://github.com/groupthinking/EventRelay/blob/main/apps/web/src/lib/__tests__/studio-handoff.test.ts), and [checkout configuration test](https://github.com/groupthinking/EventRelay/blob/main/apps/web/src/lib/billing/__tests__/checkout-config.test.ts): `npm --workspace=eventrelay-web exec -- vitest run src/lib/__tests__/home-sell-surface.test.ts src/lib/__tests__/studio-handoff.test.ts src/lib/billing/__tests__/checkout-config.test.ts` | The suite passes, and the source continues to use `HomePasteForm`, `HomeProCheckout`, and shared price configuration. | | ||
| | Responsive Home experience | In one terminal run `npm --workspace=eventrelay-web run dev`; in another run `BASE_URL=http://127.0.0.1:3000 npm --workspace=eventrelay-web exec -- playwright test playwright/home-sell-surface.spec.ts` | At 360 px and 1280 px, the heading, form, pricing summary, and checkout surface are visible with no horizontal scrolling. | |
|
|
||
| | Check | Exact evidence command | Pass condition | | ||
| |---|---|---| | ||
| | Origin G.A.T.E. and sandbox origin controls | Run `npm --workspace=eventrelay-web run test:gate`, which includes the [Origin G.A.T.E. test](https://github.com/groupthinking/EventRelay/blob/main/apps/web/src/lib/__tests__/origin-gate.test.ts) and [gate-transition test](https://github.com/groupthinking/EventRelay/blob/main/apps/web/src/lib/__tests__/gate-transition.test.ts). | The named gate, transition, Studio workflow, and sandbox-origin tests pass. This is local contract evidence only. | |
| |---|---|---| | ||
| | Origin G.A.T.E. and sandbox origin controls | Run `npm --workspace=eventrelay-web run test:gate`, which includes the [Origin G.A.T.E. test](https://github.com/groupthinking/EventRelay/blob/main/apps/web/src/lib/__tests__/origin-gate.test.ts) and [gate-transition test](https://github.com/groupthinking/EventRelay/blob/main/apps/web/src/lib/__tests__/gate-transition.test.ts). | The named gate, transition, Studio workflow, and sandbox-origin tests pass. This is local contract evidence only. | | ||
| | Static quality checks | `npm --workspace=eventrelay-web run type-check` followed by `npm --workspace=eventrelay-web run lint` | Type checking reports no errors. Lint has no errors; record any pre-existing warnings separately. | | ||
| | Repository hygiene | `git status --short --branch` followed by `git diff --check` | Work happens on a dedicated branch, the intended diff is reviewable, and there is no whitespace error. | |
| | Origin G.A.T.E. and sandbox origin controls | Run `npm --workspace=eventrelay-web run test:gate`, which includes the [Origin G.A.T.E. test](https://github.com/groupthinking/EventRelay/blob/main/apps/web/src/lib/__tests__/origin-gate.test.ts) and [gate-transition test](https://github.com/groupthinking/EventRelay/blob/main/apps/web/src/lib/__tests__/gate-transition.test.ts). | The named gate, transition, Studio workflow, and sandbox-origin tests pass. This is local contract evidence only. | | ||
| | Static quality checks | `npm --workspace=eventrelay-web run type-check` followed by `npm --workspace=eventrelay-web run lint` | Type checking reports no errors. Lint has no errors; record any pre-existing warnings separately. | | ||
| | Repository hygiene | `git status --short --branch` followed by `git diff --check` | Work happens on a dedicated branch, the intended diff is reviewable, and there is no whitespace error. | | ||
| | Secret and scope review | Review `git diff --cached` or the pull-request Files changed tab before approval. | No secret, environment file, production setting, deployment configuration, checkout behavior, or unrelated source file is included. | |
…a-checklist # Conflicts: # docs/SPRINT_QA_CHECKLIST.md Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
Head branch was pushed to by a user without write access
Resolved the merge conflict in |
PR Iteration Loop — verification and canonical-issue linkCheckpoint selected: open PR #1993 (canonical draft for evidence-gated sprint QA checklist), redirected from a stale Canonical issue/PR/branch mapping
Verification evidence (head
All local evidence referenced by Recommended pattern: Autoloop. This checkpoint is a simple, goal-driven iteration on one canonical issue/PR pair with deterministic local verification commands (vitest, type-check, lint) and no need for Chopin's real-time multiplayer coordination, Continuous AI's platform-wide automation surface, or Agentic Workflows' natural-language GitHub Actions authoring — a minimal goal-check-fix loop is the best evidence-backed fit. A repository opportunity snapshot chart (failing-workflow frequency and stale-item age) has been generated and uploaded as an asset for this run.
|
|
Closing without merge (AXIOM / keep-moving). Why: docs-only checklist rewrite is useful in spirit (Claim≠PASS) but references stale sprint PRs, E2E is red ( Not blocking product-quality cut H1 (extract reliability). Reopen only if we intentionally revive a docs-owned QA SSOT. |

Canonical issue
Closes #
Outcome
Adds a credential-free QA checklist that maps each sprint claim to an exact local command or manual observation.
Scope
Risk
Verification
Production evidence
Not applicable. This PR documents the evidence required before claiming a remote or production outcome.
Agent handoff