Skip to content

fix: recover Google sign-in after failed initiation - #1984

Closed
groupthinking wants to merge 2 commits into
mainfrom
feature/fix-login-bug-8f3b6e9a
Closed

groupthinking wants to merge 2 commits into
mainfrom
feature/fix-login-bug-8f3b6e9a

Conversation

@groupthinking

Copy link
Copy Markdown
Owner

Canonical issue

Closes #

Outcome

Restores the Google sign-in button to a retryable state after a failed initiation.

Scope

  • Included: Client-side GoogleSignInButton state recovery.
  • Explicitly excluded: Server-side auth, OAuth credentials, proxy policy.

Risk

  • Risk level: low
  • Failure mode: Button remains disabled.
  • Rollback: Revert commit.

Verification

  • Focused tests
  • Required CI
  • Review threads resolved

Production evidence

N/A (Client-side fix, verified via tests)

Agent handoff

  • One canonical issue is linked
  • No competing PR implements the same issue
  • Acceptance criteria are satisfied
  • Required checks pass on the current head
  • Human decision is requested only for product, security, irreversible infrastructure, or production approval

@vercel

vercel Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
v0-uvai Canceled Canceled v0 Sep 17, 2026 4:27am UTC

@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Repository: groupthinking/EventRelay/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 1cf4cddf-594a-4ac8-bf44-4154592fbaff


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added javascript Pull requests that update javascript code tests labels Sep 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA cf61490.
Ensure that dependencies are being submitted on PR branches. Re-running this action after a short time may resolve the issue. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@groupthinking
groupthinking requested a balanced review from Copilot September 18, 2026 20:51
@linear-code
linear-code Bot marked this pull request as ready for review September 18, 2026 20:51
@groupthinking

Copy link
Copy Markdown
Owner Author

@copilot resolve the merge conflicts in this pull request

1 similar comment
@groupthinking

Copy link
Copy Markdown
Owner Author

@copilot resolve the merge conflicts in this pull request

Copilot AI previously approved these changes Sep 18, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approved

The focused implementation matches the stated scope and includes adequate regression coverage.

Pull request overview

Restores Google OAuth initiation recovery so users can retry failed sign-ins.

Changes:

  • Recovers button state after rejection or stalled handoff.
  • Shows a generic accessible error and adds focus styling.
  • Adds tests for failures, handoff timeout, and duplicate prevention.
File summaries
File Description
GoogleSignInButton.tsx Adds retry recovery and error feedback.
GoogleSignInButton.test.tsx Covers recovery and duplicate submissions.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

…-8f3b6e9a

# Conflicts:
#	apps/web/src/app/login/GoogleSignInButton.test.tsx
#	apps/web/src/app/login/GoogleSignInButton.tsx

Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
auto-merge was automatically disabled September 18, 2026 21:06

Head branch was pushed to by a user without write access

Copilot AI commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Resolved in a535790 by merging main into this branch, fixing the two Google sign-in conflicts, and rerunning the focused login button tests plus web type-check.

@copilot resolve the merge conflicts in this pull request

Resolved in a535790 by merging main into this branch, fixing the two Google sign-in conflicts, and rerunning the focused login button tests plus web type-check.

@kk-agent

Copy link
Copy Markdown
Collaborator

AXIOM keep-moving: named survivor for GoogleSignInButton initiation-retry cluster. Duplicates #1978/#1995 closed. Linked issues #1987/#2002. Merge when CI green — do not wait on draft theater.

@kk-agent

Copy link
Copy Markdown
Collaborator

Closed — duplicate of #1971

Same Google sign-in retry residual. Canonical PR: #1971. Issue residual: #2002.

@kk-agent kk-agent closed this Sep 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update javascript code tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants