fix: recover Google sign-in after failed initiation - #1984
groupthinking wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository: groupthinking/EventRelay/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches. Re-running this action after a short time may resolve the issue. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
|
@copilot resolve the merge conflicts in this pull request |
1 similar comment
|
@copilot resolve the merge conflicts in this pull request |
There was a problem hiding this comment.
🟢 Approved
The focused implementation matches the stated scope and includes adequate regression coverage.
Pull request overview
Restores Google OAuth initiation recovery so users can retry failed sign-ins.
Changes:
- Recovers button state after rejection or stalled handoff.
- Shows a generic accessible error and adds focus styling.
- Adds tests for failures, handoff timeout, and duplicate prevention.
File summaries
| File | Description |
|---|---|
GoogleSignInButton.tsx |
Adds retry recovery and error feedback. |
GoogleSignInButton.test.tsx |
Covers recovery and duplicate submissions. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…-8f3b6e9a # Conflicts: # apps/web/src/app/login/GoogleSignInButton.test.tsx # apps/web/src/app/login/GoogleSignInButton.tsx Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
Head branch was pushed to by a user without write access
Resolved in a535790 by merging
Resolved in a535790 by merging |
Canonical issue
Closes #
Outcome
Restores the Google sign-in button to a retryable state after a failed initiation.
Scope
Risk
Verification
Production evidence
N/A (Client-side fix, verified via tests)
Agent handoff