Skip to content

redact: the comment accused go-images/images of a defect it documents on purpose #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tannevaled merged 1 commit into from
Nov 12, 2026
Merged

redact: the comment accused go-images/images of a defect it documents on purpose #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions redactimage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,22 @@ import (

// ⛔ THE FLEET'S DECODER, NOT THE STANDARD LIBRARY'S. What this promises to
// write back is "what a reader would have seen", and the reader is
// go-pdfkit/render, which decodes /DCTDecode with this fork: Go's own
// image/jpeg with a four-component picture's chroma upsampled the way
// libjpeg does rather than by repeating each sample. Decoding here with a
// different decoder would make that promise true of a picture nobody was
// shown.
// go-pdfkit/render, whose import list holds github.com/go-images/jpeg and
// not image/jpeg: Go's own decoder with a four-component picture's chroma
// upsampled the way libjpeg does rather than by repeating each sample.
// Decoding here with a different decoder would make that promise true of a
// picture nobody was shown.
//
// ⛔ AND IT IS NOT ABOUT THE BINARY. This was first written claiming it
// saved linking a second decoder; `go list -deps` says otherwise, before
// and after. image/jpeg stays, because go-gfx/gfx/codec, go-images/images
// and go-pdfkit/html2pdf each import it — go-images/images imports BOTH.
// That is a wider divergence than this file, filed rather than fixed here.
// ⛔ THE REASON IS NOT BINARY SIZE, AND THE OTHER IMPORTERS ARE NOT A
// DEFECT — two claims this comment made before anyone checked them.
// `go list -deps` says image/jpeg stays either way, pulled in by
// go-gfx/gfx/codec, go-images/images and go-pdfkit/html2pdf. And
// go-images/images imports both ON PURPOSE: its own doc says PNG and JPEG
// decode through the standard library, while partial.go uses the fork for
// DecodePartial and states the four-component divergence in so many words
// — "Decode's standard-library path is untouched, so anything relying on
// its exact bytes still gets them". Two issues were nearly filed on that.
// Reading the dependency's source is what stopped them.
"github.com/go-images/jpeg"
"github.com/go-pdfkit/extract"
"github.com/go-pdfkit/reader"
Expand Down
Loading