Repository navigation
redact: the comment accused go-images/images of a defect it documents on purpose - #91
Merged
Merged
Conversation
… on purpose ⛔⛔ I WROTE TWO CLAIMS INTO A SHIPPED COMMENT WITHOUT CHECKING EITHER, and was one command away from filing two issues in other organisations on the strength of them. The comment added in #89 said the import swap saved linking a second decoder — already corrected in that pull request, `go list -deps` says image/jpeg stays either way — and then that go-gfx/gfx/codec, go-images/images and go-pdfkit/html2pdf importing image/jpeg is "a wider divergence than this file", with go-images/images importing BOTH singled out as the worst of it. Reading that dependency's source says otherwise, and says it deliberately. Its package doc: "PNG and JPEG via the standard library". Its partial.go, which is the only file importing the fork: ⛔ One divergence from [Decode], stated rather than hidden. On a COMPLETE file this returns the FORK's decode, and for a four-component JPEG that differs: the fork upsamples chroma the way libjpeg does, where the standard library repeats each sample. Decode's standard-library path is untouched, so anything relying on its exact bytes still gets them. So the two decoders live there on purpose, the divergence is written down where the divergence is made, and there is nothing to file. A tracker entry claiming otherwise would have cost a maintainer a reading to refute. ⛔ WHAT SURVIVES THE CHECK IS THE CHANGE ITSELF. go-pdfkit/render's import list holds github.com/go-images/jpeg and NOT image/jpeg, so decoding a redacted picture with the fork really is decoding it the way the page is shown. That was the reason; the rest was decoration I had not earned. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⛔⛔ Two claims went into a shipped comment without either being checked,
and I was one command away from filing two issues in other organisations on the
strength of them.
The comment added in #89 said the import swap saved linking a second decoder —
already corrected inside that pull request,
go list -depssaysimage/jpegstays either way — and then that
go-gfx/gfx/codec,go-images/imagesandgo-pdfkit/html2pdfimportingimage/jpegis "a wider divergence than thisfile", with
go-images/imagesimporting both singled out as the worst ofit.
Reading that dependency's source says otherwise, and says it deliberately
Its package doc: "PNG and JPEG via the standard library". Its
partial.go,the only file importing the fork:
So the two decoders live there on purpose, the divergence is written down
exactly where the divergence is made, and there is nothing to file. A tracker
entry claiming otherwise would have cost a maintainer a reading to refute.
What survives the check is the change itself
go-pdfkit/render's import list holdsgithub.com/go-images/jpegand notimage/jpeg, so decoding a redacted picture with the fork really is decodingit the way the page is shown. That was the reason; the rest was decoration I
had not earned.
🤖 Generated with Claude Code