Skip to content

fix: close HTTP response bodies in helper requests #3295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wangjingshuiku wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: close HTTP response bodies in helper requests #3295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions cmd/open.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,11 +258,15 @@ func openURL(url string, kubectlClient kubectl.Client, analyzeNamespace string,
for time.Since(now) < maxWait {
// Check if domain is ready => ignore error as we will retry request
resp, _ := http.Get(url)
if resp != nil && resp.StatusCode != http.StatusBadGateway && resp.StatusCode != http.StatusServiceUnavailable {
time.Sleep(time.Second * 1)
_ = open.Start(url)
log.Donef("Successfully opened %s", url)
return nil
if resp != nil {
statusCode := resp.StatusCode
_ = resp.Body.Close()
if statusCode != http.StatusBadGateway && statusCode != http.StatusServiceUnavailable {
time.Sleep(time.Second * 1)
_ = open.Start(url)
log.Donef("Successfully opened %s", url)
return nil
}
}

if kubectlClient != nil && analyzeNamespace != "" {
Expand Down
1 change: 1 addition & 0 deletions pkg/devspace/build/builder/restart/restart.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@ func loadRestartHelper(path, defaultScript string) (string, error) {
if err != nil {
return "", err
}
defer resp.Body.Close()

out, err := io.ReadAll(resp.Body)
if err != nil {
Expand Down