fix: close HTTP response bodies in helper requests - #3295
Open
wangjingshuiku wants to merge 1 commit into
Open
Conversation
Signed-off-by: wangjingshuiku <wangjingshuiku@163.com>
wangjingshuiku
requested review from
FabianKramm and
LukasGentele
as code owners
August 24, 2026 17:20
✅ Deploy Preview for devspace-docs canceled.Built without sensitive environment variables
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address?
/kind bugfix
What does this pull request do? Which issues does it resolve?
Closes HTTP response bodies in the URL readiness polling loop and after downloading the restart helper. This prevents connections and file descriptors from being retained across retries. No associated issue.
Please provide a short message that should be published in the DevSpace release notes
Fixed an issue where repeated URL readiness checks and restart-helper downloads could retain HTTP resources.
What else do we need to know?
go test ./pkg/devspace/build/builder/restartpasses. The changedcmdpackage was formatted withgofmt, andgit diff --checkpasses.