Repository navigation
Conversation
This was referenced Nov 13, 2026
HsingTang
force-pushed
the
HsingTang/stack/sandbox-ssh-port-forward
branch
from
November 13, 2026 08:25
5cd926a to
417c077
Compare
Collaborator
✅ Integration test reportCommit: 9434fda
Top 3 slowest tests (at least 2 minutes):
|
HsingTang
force-pushed
the
HsingTang/stack/sandbox-websocket-server
branch
from
November 13, 2026 21:16
d3e8539 to
e27bc56
Compare
HsingTang
force-pushed
the
HsingTang/stack/sandbox-ssh-port-forward
branch
from
November 13, 2026 21:43
417c077 to
5441e69
Compare
HsingTang
force-pushed
the
HsingTang/stack/sandbox-ssh-port-forward
branch
from
November 13, 2026 22:12
5441e69 to
9434fda
Compare
HsingTang
force-pushed
the
HsingTang/stack/sandbox-websocket-server
branch
from
November 13, 2026 22:12
e27bc56 to
36dc63c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Changes
Change
databricks sandbox sshto use local SSH keys and authenticated WebSocket port forwarding. Its internal--proxymode prepares expiring public-key entries through command execution, uploads a compatible Linux CLI, starts the internal sandbox server, pins its host key, and cleans up the remote command.Keep sandbox implementation code in
experimental/ssh/sandboxand reuse the existing SSH key, configuration, and relay helpers at their original paths. Share cancellable release downloads throughexperimental/ssh/internal/releases.Why
Keep the existing SSH command while removing its dependence on the Gateway SSH listener and key registry. This change requires the sandbox port-forwarding backend and must ship after that backend is available. It does not fall back to direct Gateway SSH.
Tests
./task test-sandbox test-exp-ssh, affected race tests, and./task fmt checks lintpass. Tests cover authentication settings, TLS/gRPC and WebSocket requests, startup deadlines, readiness, stalled output, cancellation, and cleanup. Native OpenSSH tests exercise commands and exit status, PTYs, SCP, SFTP, and expired-key rejection.The package-layout change was reviewed locally with Isaac, with no blocking findings. Live workspace validation is pending availability of the forwarding backend; local fixtures do not establish deployed end-to-end support.
This PR was written with Codex.