Repository navigation
Conversation
This was referenced Nov 13, 2026
Collaborator
✅ Integration test reportCommit: 36dc63c
Top 3 slowest tests (at least 2 minutes):
|
HsingTang
force-pushed
the
HsingTang/stack/sandbox-websocket-server
branch
from
November 13, 2026 21:16
d3e8539 to
e27bc56
Compare
HsingTang
changed the title
HsingTang
force-pushed
the
HsingTang/stack/sandbox-websocket-server
branch
from
November 13, 2026 22:12
e27bc56 to
36dc63c
Compare
HsingTang
marked this pull request as ready for review
November 13, 2026 22:18
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
Changes
Add the hidden, internal
databricks sandbox servercommand. It accepts WebSocket connections and connects each SSH stream tosshd -i, using a prepared configuration.Keep the existing relay in
experimental/ssh/internal/proxyand put the new sandbox implementation inexperimental/ssh/sandbox. Existing SSH files stay at their original paths. Allow experimental imports only in the four sandbox SSH command integration files.Why
Sandbox SSH needs a server that works through HTTP/WebSocket port forwarding without compute-specific setup. Adding this command first leaves the current sandbox SSH command unchanged.
Tests
Sandbox and compute SSH unit and acceptance tests pass with
./task test-sandbox test-exp-ssh. Race tests cover binary transport, readiness failures, connection admission, cancellation, child cleanup, and idle shutdown. Formatting, checks, and lint pass.The package-layout change was reviewed locally with Isaac, with no blocking findings.
This PR was written with Codex.