Repository navigation
air: explain root_path and default retries in convert-to-dabs - #7579
Merged
Merged
Conversation
convert-to-dabs rejects a code_source root_path that resolves to the bundle root without saying how to proceed, and writes the air run default max_retries into the bundle without mentioning it. Point at the subdirectory and --output-dir fixes in the error, and print a note when the generated job carries the default retry settings. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Commit: Regression test reportSelected 1 changed tests (limit=20, 0 not selected) 1 tests: regression=1 unreleased=0 coverage=0 failing=0
TestAccept/air/convert-to-dabs: branch ✅ | main (db52460) ❌ | latest (v1.26.0) ❌main (db52460): latest (v1.26.0): same output as main (db52460) |
A git snapshot is archived from the bundle root, so rooting the bundle at a parent directory fails at deploy. Offer --output-dir only when there is no git ref, derive retry_on_timeout in the retry note, fix comments the new error made stale, and cover the plain-snapshot rejection, the parent output-dir conversion, and note suppression at the command level. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
✅ Integration test reportCommit: b58c19e
10 interesting tests: 9 flaky, 1 RECOVERED
Top 30 slowest tests (at least 2 minutes):
|
ethanma-db
approved these changes
Nov 13, 2026
Collaborator
❌ Integration test reportCommit: bdb37ab
14 interesting tests: 9 RECOVERED, 5 flaky
Top 50 slowest tests (at least 2 minutes):
|
This was referenced Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
air convert-to-dabs: whencode_source.root_pathresolves to the bundle root, the error now says how to proceed: move the code into a subdirectory (for example./src). For working-tree snapshots it also offers--output-dirwith a dedicated parent directory. That option is not offered for git snapshots, because the archive runs from the bundle root and a parent directory would sit outside the repository.max_retries, the command prints a note after the next steps saying the generated job carries theair rundefault (max_retries: 3,retry_on_timeout: true).Why
Converting a workload that uses
root_path: .(a common starter layout) fails with an error that only says to pointroot_pathat a subdirectory, with no mention of--output-dir. After a successful conversion,databricks.ymlcontainsmax_retries: 3andretry_on_timeout: truethat are not in the source YAML, which reads as if the conversion invented them. The values are correct (they are whatair runsubmits when the field is unset), so the emitted bundle is unchanged; this only makes the behavior visible.Tests
TestConvertToDabsDotRootPathRejectednow covers plain, include and git snapshots, and asserts the--output-dirhint is present for the first two and absent for git.TestConvertToDabsDotRootPathWithParentOutputDirconverts with the bundle rooted at the parent and checks the emitted artifactpathandinclude.TestConvertToDabsCommandPrintsRetryNoteOnlyWhenUnsetruns the command and checks the note appears only whenmax_retriesis unset;TestRetryDefaultsNotecovers the helper.go test ./cmd/airandgo test ./acceptance -run TestAccept/air/convert-to-dabspass on this branch.acceptance/air/convert-to-dabs/output.txtwas edited by hand rather than with-update; the acceptance run confirms it matches.This pull request and its description were written by Isaac.