Repository navigation
Conversation
…ide the bundle When code_source.root_path resolved outside the bundle directory, for example the getting-started Ray recipes that snapshot their parent directory with root_path: .., convert-to-dabs suggested setting sync.paths in a databricks.yml that it had not written. The error now names the resolved code directory and, for working-tree snapshots, the --output-dir value that converts the workload. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Thanks for the contribution! This pull request was opened from a fork. If you're a member of the Databricks organization, please request access to the If you're an external contributor, no action is needed; a maintainer will review your pull request. |
Contributor
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Member
Author
|
Superseded by #7644, which uses a branch in this repository so CI can run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
air convert-to-dabs: whencode_source.root_pathresolves outside the bundle directory, the error names the resolved code directory and, for working-tree snapshots, the--output-dirthat converts the workload (the code directory's parent). It no longer suggests settingsync.pathsindatabricks.yml.Why
The getting-started Ray recipes in the AI Runtime cookbook snapshot their parent directory (
root_path: ..) to include a shared bootstrap. Runningconvert-to-dabs workload.yamlfrom the recipe directory failed with advice to setsync.pathsin adatabricks.ymlthat the command had not written, and the generated bundle only syncsgenerated_artifactswhile thetgzartifact packages code inside the bundle anyway. The conversion works with--output-dir ../.., which no message mentioned.Tests
TestConvertToDabsCodeOutsideBundleSuggestsOutputDirreproduces the Ray layout: the error names--output-dir <parent>and notsync.paths, and converting with that directory succeeds with the expected artifactinclude.TestConvertToDabsGitPinOutsideBundleDoesNotSuggestOutputDirchecks git-pinned snapshots get no--output-dirhint.TestConvertToDabsRejectsCodeOutsideBundlepasses unchanged.go test ./cmd/air/...andgo test ./acceptance -run TestAccept/airpass;golangci-lint run ./cmd/air/...reports no issues.This pull request and its description were written by Isaac.