Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 29 additions & 28 deletions internal/build/labeler_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,48 +20,49 @@ func TestLabelerTestOnlyDirsNotInBinary(t *testing.T) {

var config struct {
TestOnlyFix []struct {
ChangedFiles []struct {
AnyGlobToAllFiles []string `yaml:"any-glob-to-all-files"`
} `yaml:"changed-files"`
ChangedFiles []map[string][]string `yaml:"changed-files"`
} `yaml:"test-only-fix"`
}
require.NoError(t, yaml.Unmarshal(raw, &config))
glob := config.TestOnlyFix[0].ChangedFiles[0].AnyGlobToAllFiles[0]

// The labeler ORs extra rules and globs into the label, and this test reads only
// one glob, so a config that grows another one must fail here until it is covered.
require.Len(t, config.TestOnlyFix, 1)
require.Len(t, config.TestOnlyFix[0].ChangedFiles, 1)
match := config.TestOnlyFix[0].ChangedFiles[0]
require.Len(t, match, 1)
globs := match["any-glob-to-all-files"]
require.Len(t, globs, 1)

// Directory entries look like "libs/testserver/**". Entries such as
// "**/*_test.go" match by file name and are skipped.
var dirs []string
for alt := range strings.SplitSeq(strings.Trim(glob, "{}"), ",") {
for alt := range strings.SplitSeq(strings.Trim(globs[0], "{}"), ",") {
dir, ok := strings.CutSuffix(alt, "/**")
if ok && !strings.Contains(dir, "*") {
dirs = append(dirs, dir)
}
}
require.NotEmpty(t, dirs)

// Release targets from .goreleaser.yaml; some files build only on some of them.
for _, target := range []string{"linux/amd64", "linux/arm64", "darwin/amd64", "darwin/arm64", "windows/amd64", "windows/arm64"} {
t.Run(target, func(t *testing.T) {
t.Parallel()
goos, goarch, _ := strings.Cut(target, "/")
// go test does not see the sources go list reads, so a cached local pass can be
// stale. CI reruns it because a fresh checkout changes the config file's mtime.
cmd := exec.CommandContext(t.Context(), "go", "list", "-deps", "-f", "{{.ImportPath}}", ".")
cmd.Dir = "../.."
cmd.Env = append(os.Environ(), "GOOS="+goos, "GOARCH="+goarch, "CGO_ENABLED=0")
out, err := cmd.Output()
require.NoError(t, err)
// go list resolves build constraints for the host platform only. CI runs this test
// on Linux, macOS and Windows, which covers the OS-specific files.
// go test does not see the sources go list reads, so a cached local pass can be
// stale. CI reruns it because a fresh checkout changes the config file's mtime.
cmd := exec.CommandContext(t.Context(), "go", "list", "-deps", "-f", "{{.ImportPath}}", ".")
cmd.Dir = "../.."
cmd.Env = append(os.Environ(), "CGO_ENABLED=0")
out, err := cmd.Output()
require.NoError(t, err)

for pkg := range strings.FieldsSeq(string(out)) {
rel, ok := strings.CutPrefix(pkg, "github.com/databricks/cli/")
if !ok {
continue
}
for _, dir := range dirs {
assert.False(t, rel == dir || strings.HasPrefix(rel, dir+"/"),
"CLI binary imports %s, but .github/labeler-test-only.yml lists %s/** as test-only", pkg, dir)
}
}
})
for pkg := range strings.FieldsSeq(string(out)) {
rel, ok := strings.CutPrefix(pkg, "github.com/databricks/cli/")
if !ok {
continue
}
for _, dir := range dirs {
assert.False(t, rel == dir || strings.HasPrefix(rel, dir+"/"),
"CLI binary imports %s, but .github/labeler-test-only.yml lists %s/** as test-only", pkg, dir)
}
}
}
Loading