Repository navigation
Conversation
Fail when the test-only-fix config grows a second rule, match type or glob, since the test reads only one and the labeler would OR the rest in. Read the release targets from .goreleaser.yaml instead of hardcoding them. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
✅ Integration test reportCommit: 1e79697
Top 6 slowest tests (at least 2 minutes):
|
All release targets give the same CLI import graph, and the only platform-specific CLI files import nothing from the CLI. CI runs the test on Linux, macOS and Windows, which covers the OS-specific files, so drop the per-target loop and the .goreleaser.yaml parsing. Co-authored-by: Isaac <no-reply@databricks.com>
andrewnester
approved these changes
Nov 15, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Follow-up to #7462, addressing post-merge review of
TestLabelerTestOnlyDirsNotInBinary:.github/labeler-test-only.yml. The labeler would OR any extra one into the label, and the test reads only one.go list -depsonce for the host platform instead of once per release target.Why
Before, adding a second glob would leave the guard silently incomplete.
The per-target loop added nothing. All 6 release targets give the same CLI import graph (393 packages, 2044 CLI-to-CLI import edges). The only platform-specific CLI files split by OS (unix vs Windows), and they import nothing from the CLI. CI runs this unit test on Linux, macOS and Windows, so an OS-specific import of a test-only package would still fail on the matching job.
Tests
I added each of these locally and confirmed the test fails: a second glob, a sibling match key, a second
changed-filesblock, and a test-only entry the binary imports (libs/log/**).This pull request and its description were written by Isaac.